Fix golangci-lint static analysis failures

Author: stanhu

commands/multi.go

@@ -172,7 +172,7 @@ func (mr *RunCommand) Start(_ service.Service) error {
 
 	userModeWarning(false)
 
-	if len(mr.WorkingDirectory) > 0 {
+	if mr.WorkingDirectory != "" {
 		err := os.Chdir(mr.WorkingDirectory)
 		if err != nil {
 			return err

commands/reset_token.go

@@ -52,7 +52,7 @@ func (c *ResetTokenCommand) resetSingleRunnerToken() bool {
 }
 
 func (c *ResetTokenCommand) getRunnerCredentials() (*common.RunnerCredentials, error) {
-	if len(c.Name) > 0 {
+	if c.Name != "" {
 		runnerConfig, err := c.RunnerByName(c.Name)
 		if err != nil {
 			return nil, err

common/build.go

@@ -1276,8 +1276,8 @@ func (b *Build) expandContainerOptions() {
 	}
 }
 
-func (b *Build) getURLWithAuth(URL string) string {
-	u, _ := url.Parse(URL)
+func (b *Build) getURLWithAuth(repoURL string) string {
+	u, _ := url.Parse(repoURL)
 
 	if u.Scheme == "ssh" {
 		if u.User == nil {

common/config.go

@@ -667,7 +667,7 @@ func (s *KubernetesPodSpec) PodSpecPatch() ([]byte, KubernetesPodSpecPatchType,
 	}
 
 	if s.PatchPath != "" {
-		if len(s.Patch) > 0 {
+		if s.Patch != "" {
 			return nil, "", fmt.Errorf("%w (%s)", errPatchAmbiguous, s.Name)
 		}
 

executors/docker/internal/volumes/manager_test.go

@@ -139,7 +139,7 @@ func TestDefaultManager_CreateUserVolumes_HostVolume(t *testing.T) {
 			err := m.Create(context.Background(), existingBinding)
 			require.NoError(t, err)
 
-			if len(testCase.volume) > 0 {
+			if testCase.volume != "" {
 				volumeParser.On("ParseVolume", testCase.volume).
 					Return(testCase.parsedVolume, nil).
 					Once()
@@ -215,7 +215,7 @@ func TestDefaultManager_CreateUserVolumes_CacheVolume_Disabled(t *testing.T) {
 			err := m.Create(context.Background(), "/host:/duplicated")
 			require.NoError(t, err)
 
-			if len(testCase.volume) > 0 {
+			if testCase.volume != "" {
 				volumeParser.On("ParseVolume", testCase.volume).
 					Return(testCase.parsedVolume, nil).
 					Once()

executors/internal/autoscaler/acquisition_test.go

@@ -223,10 +223,8 @@ func TestAcquisitionRef_Prepare(t *testing.T) {
 				if tc.tunnelDialErr != nil || tc.mockNestingClientDelete {
 					nestingClient.EXPECT().Delete(mock.Anything, testVM.id).Return(nil).Once()
 				}
-			} else {
-				if tc.mockDialerClose {
-					fleetingDialer.EXPECT().Close().Return(nil).Once()
-				}
+			} else if tc.mockDialerClose {
+				fleetingDialer.EXPECT().Close().Return(nil).Once()
 			}
 
 			logger, _ := test.NewNullLogger()

executors/kubernetes/kubernetes.go

@@ -894,12 +894,11 @@ func (s *executor) buildPermissionsInitContainer(os string) (api.Container, erro
 }
 
 func (s *executor) buildRedirectionCmd(shell string) string {
-	switch shell {
-	// powershell outputs utf16, so we re-encode the output to utf8
-	// this is important because our json decoder that detects the exit status
-	// of a job requires utf8.Converting command output to strings with %{"$_"}
-	// prevents a powershell complaint about native command output on stderr.
-	case shells.SNPowershell:
+	if shell == shells.SNPowershell {
+		// powershell outputs utf16, so we re-encode the output to utf8
+		// this is important because our json decoder that detects the exit status
+		// of a job requires utf8.Converting command output to strings with %{"$_"}
+		// prevents a powershell complaint about native command output on stderr.
 		return fmt.Sprintf("2>&1 | %%{ \"$_\" } | Out-File -Append -Encoding UTF8 %s", s.logFile())
 	}
 
@@ -2207,7 +2206,7 @@ func (s *executor) getDNSPolicy() api.DNSPolicy {
 }
 
 func (s *executor) getHelperImage() string {
-	if len(s.Config.Kubernetes.HelperImage) > 0 {
+	if s.Config.Kubernetes.HelperImage != "" {
 		return s.ExpandValue(s.Config.Kubernetes.HelperImage)
 	}
 

executors/kubernetes/kubernetes_test.go

@@ -1025,10 +1025,8 @@ func TestCleanup(t *testing.T) {
 			Pod:      nil, // a failed POD create request will cause a nil Pod
 			Services: []api.Service{{ObjectMeta: objectMeta}},
 			ClientFunc: func(t *testing.T, req *http.Request) (*http.Response, error) {
-				switch p, m := req.URL.Path, req.Method; {
-				default:
-					return nil, fmt.Errorf("unexpected request. method: %s, path: %s", m, p)
-				}
+				p, m := req.URL.Path, req.Method
+				return nil, fmt.Errorf("unexpected request. method: %s, path: %s", m, p)
 			},
 			Error: false,
 		},

executors/kubernetes/terminal.go

@@ -51,7 +51,7 @@ func (s *executor) getTerminalSettings() (*terminal.TerminalSettings, error) {
 	wsURL := s.getTerminalWebSocketURL()
 
 	caCert := ""
-	if len(config.CAFile) > 0 {
+	if config.CAFile != "" {
 		buf, err := os.ReadFile(config.CAFile)
 		if err != nil {
 			return nil, err

executors/kubernetes/util.go

@@ -48,7 +48,7 @@ func getKubeClientConfig(
 	config *common.KubernetesConfig,
 	overwrites *overwrites,
 ) (kubeConfig *restclient.Config, err error) {
-	if len(config.Host) > 0 {
+	if config.Host != "" {
 		kubeConfig, err = getOutClusterClientConfig(config)
 	} else {
 		kubeConfig, err = guessClientConfig()

helpers/container/services/services.go

@@ -45,7 +45,7 @@ func SplitNameAndVersion(serviceDescription string) Service {
 	service := Service{}
 	service.Service = registry + imageName
 
-	if len(imageVersion) > 0 {
+	if imageVersion != "" {
 		service.ImageName = serviceDescription
 		service.Version = imageVersion
 	} else {

helpers/parallels/control.go

@@ -121,7 +121,7 @@ func GetDefaultSnapshot(vmName string) (string, error) {
 		if pos >= 0 {
 			snapshot := line[pos+2:]
 			snapshot = strings.TrimSpace(snapshot)
-			if len(snapshot) > 0 { // It uses UUID so it should be 38
+			if snapshot != "" { // It uses UUID so it should be 38
 				return snapshot, nil
 			}
 		}

helpers/vault/client.go

@@ -72,9 +72,9 @@ var (
 	}
 )
 
-func NewClient(URL string, namespace string) (Client, error) {
+func NewClient(apiURL string, namespace string) (Client, error) {
 	config := &api.Config{
-		Address: URL,
+		Address: apiURL,
 	}
 
 	client, err := newAPIClient(config)

network/client.go

@@ -84,7 +84,7 @@ func (n *client) getLastUpdate() string {
 }
 
 func (n *client) setLastUpdate(headers http.Header) {
-	if lu := headers.Get("X-GitLab-Last-Update"); len(lu) > 0 {
+	if lu := headers.Get("X-GitLab-Last-Update"); lu != "" {
 		n.lastUpdate = lu
 	}
 }

network/gitlab_test.go

@@ -2296,7 +2296,7 @@ func checkTestArtifactsUploadHandlerContent(w http.ResponseWriter, r *http.Reque
 
 	w.Header().Set(ContentType, "application/json")
 
-	if len(testCase.formValueKey) > 0 {
+	if testCase.formValueKey != "" {
 		if r.FormValue(testCase.formValueKey) != body {
 			return
 		}