Skip to content

Commit 2747f2d

Browse files
committed
link tag maps to nothing
- according to https://www.w3.org/TR/html-aam-1.0/, link tag doesn't map to anything even with an href. - therefore, it no longer makes sense to try to determine role and evaluate, so it should be skipped. - accordingly, tests are deleted since we don't want to evaluate it.
1 parent 762f7e1 commit 2747f2d

File tree

1 file changed

+1
-29
lines changed

1 file changed

+1
-29
lines changed

tests/role-supports-aria-props.js

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -75,27 +75,6 @@ ruleTester.run('role-supports-aria-props', rule, {
7575
{code: '<area href="#" aria-owns />'},
7676
{code: '<area href="#" aria-relevant />'},
7777

78-
// LINK TESTS - implicit role is `link`
79-
{code: '<link href="#" aria-expanded />'},
80-
{code: '<link href="#" aria-atomic />'},
81-
{code: '<link href="#" aria-busy />'},
82-
{code: '<link href="#" aria-controls />'},
83-
{code: '<link href="#" aria-describedby />'},
84-
{code: '<link href="#" aria-disabled />'},
85-
{code: '<link href="#" aria-dropeffect />'},
86-
{code: '<link href="#" aria-flowto />'},
87-
{code: '<link href="#" aria-grabbed />'},
88-
{code: '<link href="#" aria-hidden />'},
89-
{code: '<link href="#" aria-haspopup />'},
90-
{code: '<link href="#" aria-label />'},
91-
{code: '<link href="#" aria-labelledby />'},
92-
{code: '<link href="#" aria-live />'},
93-
{code: '<link href="#" aria-owns />'},
94-
{code: '<link href="#" aria-relevant />'},
95-
96-
// this will have global
97-
{code: '<link aria-checked />'},
98-
9978
// this will have role of `img`
10079
{code: '<img alt="foobar" aria-busy />'},
10180

@@ -338,6 +317,7 @@ ruleTester.run('role-supports-aria-props', rule, {
338317
{code: '<datalist aria-expanded />'},
339318
{code: '<div role="heading" aria-level />'},
340319
{code: '<div role="heading" aria-level="1" />'},
320+
{code: '<link href="#" aria-expanded />'}, // link maps to nothing
341321
],
342322

343323
invalid: [
@@ -358,10 +338,6 @@ ruleTester.run('role-supports-aria-props', rule, {
358338
code: '<area href="#" aria-checked />',
359339
errors: [getErrorMessage('aria-checked', 'link')],
360340
},
361-
{
362-
code: '<link href="#" aria-checked />',
363-
errors: [getErrorMessage('aria-checked', 'link')],
364-
},
365341
{
366342
code: '<img alt="foobar" aria-checked />',
367343
errors: [getErrorMessage('aria-checked', 'img')],
@@ -482,10 +458,6 @@ ruleTester.run('role-supports-aria-props', rule, {
482458
code: '<menu type="toolbar" aria-expanded />',
483459
errors: [getErrorMessage('aria-expanded', 'toolbar')],
484460
},
485-
{
486-
code: '<link href="#" aria-invalid />',
487-
errors: [getErrorMessage('aria-invalid', 'link')],
488-
},
489461
{
490462
code: '<area href="#" aria-invalid />',
491463
errors: [getErrorMessage('aria-invalid', 'link')],

0 commit comments

Comments
 (0)