Use propValue for anything else

Author: khiga8

lib/utils/get-role.js

@@ -1,4 +1,4 @@
-const {getProp, getLiteralPropValue} = require('jsx-ast-utils')
+const {getProp, getPropValue, getLiteralPropValue} = require('jsx-ast-utils')
 const {elementRoles} = require('aria-query')
 const {getElementType} = require('./get-element-type')
 const ObjectMap = require('./object-map')
@@ -80,7 +80,7 @@ function getRole(context, node) {
       continue
     }
 
-    const value = getLiteralPropValue(propOnNode)
+    const value = getPropValue(propOnNode)
     if (value || (value === '' && prop === 'alt')) {
       if (
         prop === 'href' ||

tests/a11y-role-supports-aria-props.js

@@ -35,11 +35,11 @@ ruleTester.run('a11y-role-supports-aria-props', rule, {
     {code: '<div role />'},
     {code: '<div role="presentation" {...props} />'},
     {code: '<Foo.Bar baz={true} />'},
+    {code: '<Foo as="a" href={url} aria-label={`Issue #${title}`} />'},
     {code: '<Link href="#" aria-checked />'},
     // Don't try to evaluate expression
     {code: '<Box aria-labelledby="some-id" role={role} />'},
-    {code: '<Box aria-labelledby="some-id"as={isNavigationOpen ? "div" : "nav"} />'},
-
+    {code: '<Box aria-labelledby="some-id" as={isNavigationOpen ? "div" : "nav"} />'},
     // IMPLICIT ROLE TESTS
     // A TESTS - implicit role is `link`
     {code: '<a href="#" aria-expanded />'},

tests/utils/get-role.js

@@ -46,6 +46,14 @@ describe('getRole', function () {
     expect(getRole({}, node)).to.equal('link')
   })
 
+  it('returns link role for <Foo> with polymorphic prop set to "a" and href', function () {
+    const node = mockJSXOpeningElement('Foo', [
+      mockJSXAttribute('as', 'a'),
+      [mockJSXConditionalAttribute('href', 'getUrl', '#', 'https://github.com/')],
+    ])
+    expect(getRole({}, node)).to.equal('link')
+  })
+
   it('returns region role for <section> with aria-label', function () {
     const node = mockJSXOpeningElement('section', [mockJSXAttribute('aria-label', 'something')])
     expect(getRole({}, node)).to.equal('region')