Swift: Use the PostUpdateNode.

geoffw0 · geoffw0 · commit e60dc9a9edda · 2023-12-05T14:48:46.000Z
diff --git a/swift/ql/lib/codeql/swift/frameworks/Heuristic.qll b/swift/ql/lib/codeql/swift/frameworks/Heuristic.qll
@@ -86,7 +86,7 @@ private class AppendCallStep extends AdditionalTaintStep {
       ce.getStaticTarget().(Function).getShortName() = ["append", "insert"] and
       arg.getLabel() = ["", "contentsOf"] and
       node1.asExpr() = arg.getExpr() and
-      node2.asExpr() = ce.getQualifier()
+      node2.(DataFlow::PostUpdateNode).getPreUpdateNode().asExpr() = ce.getQualifier()
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ private class AppendCallStep extends AdditionalTaintStep {`
`86`	`86`	`ce.getStaticTarget().(Function).getShortName() = ["append", "insert"] and`
`87`	`87`	`arg.getLabel() = ["", "contentsOf"] and`
`88`	`88`	`node1.asExpr() = arg.getExpr() and`
`89`		`- node2.asExpr() = ce.getQualifier()`
	`89`	`+ node2.(DataFlow::PostUpdateNode).getPreUpdateNode().asExpr() = ce.getQualifier()`
`90`	`90`	`)`
`91`	`91`	`}`
`92`	`92`	`}`