Add replace to MapMutator

egregius313 · egregius313 · commit ce130c6ed514 · 2023-12-19T10:23:06.000-05:00
diff --git a/java/ql/lib/semmle/code/java/Maps.qll b/java/ql/lib/semmle/code/java/Maps.qll
@@ -40,7 +40,9 @@ class MapMethod extends Method {
 
 /** A method that mutates the map it belongs to. */
 class MapMutator extends MapMethod {
-  MapMutator() { pragma[only_bind_into](this).getName().regexpMatch("(put.*|remove|clear)") }
+  MapMutator() {
+    pragma[only_bind_into](this).getName().regexpMatch("(put.*|remove|clear|replace.*)")
+  }
 }
 
 /** The `size` method of `java.util.Map`. */

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,9 @@ class MapMethod extends Method {`
`40`	`40`
`41`	`41`	`/** A method that mutates the map it belongs to. */`
`42`	`42`	`class MapMutator extends MapMethod {`
`43`		`- MapMutator() { pragma[only_bind_into](this).getName().regexpMatch("(put.*\|remove\|clear)") }`
	`43`	`+ MapMutator() {`
	`44`	`+ pragma[only_bind_into](this).getName().regexpMatch("(put.\|remove\|clear\|replace.)")`
	`45`	`+ }`
`44`	`46`	`}`
`45`	`47`
`46`	`48`	/** The `size` method of `java.util.Map`. */