C++: Force LF for .c,.cpp,.h,.hpp

Author: dave-bartolomeo

.editorconfig

@@ -1,2 +1,2 @@
-[*.{ql,qll,qlref,dbscheme,qhelp,html,js,mjs,ts,json,yml}]
+[*.{ql,qll,qlref,dbscheme,qhelp,html,js,mjs,ts,json,yml,c,cpp,h,hpp}]
 end_of_line = lf

.gitattributes

@@ -21,3 +21,7 @@
 *.ts eol=lf
 *.json eol=lf
 *.yml eol=lf
+*.c eol=lf
+*.cpp eol=lf
+*.h eol=lf
+*.hpp eol=lf

cpp/ql/src/Architecture/Refactoring Opportunities/ClassesWithManyDependencies.cpp

@@ -1,17 +1,17 @@
-// an include declaration just adds one source dependency, it does not automatically
-// add a dependency from this file to all the declarations in stdio.h
-#include <stdio.h>
-#include <myfile.h> // contains non-static global myfile_err
-
-extern int myfile_err; // this external declaration adds a dependency on myfile.h
-
-class C {
-public:
-	C() {
-		// one dependency for printf:
-		printf("Hello world!");
-		// one dependency for FILE type, and one for NULL macro:
-		FILE fp = NULL;
-	}
-};
-
+// an include declaration just adds one source dependency, it does not automatically
+// add a dependency from this file to all the declarations in stdio.h
+#include <stdio.h>
+#include <myfile.h> // contains non-static global myfile_err
+
+extern int myfile_err; // this external declaration adds a dependency on myfile.h
+
+class C {
+public:
+	C() {
+		// one dependency for printf:
+		printf("Hello world!");
+		// one dependency for FILE type, and one for NULL macro:
+		FILE fp = NULL;
+	}
+};
+

cpp/ql/src/Architecture/Refactoring Opportunities/ClassesWithManyFields.cpp

@@ -1,20 +1,20 @@
-//This struct contains 30 fields.
-struct MyParticle {
-  bool isActive;
-  int priority;
-
-  float x, y, z;
-  float dx, dy, dz;
-  float ddx, ddy, ddz;
-  bool isCollider;
-
-  int age, maxAge;
-  float size1, size2;
-
-  bool hasColor;
-  unsigned char r1, g1, b1, a1;
-  unsigned char r2, g2, b2, a2;
-
-  class texture *tex;
-  float u1, v1, u2, v2;
-};
+//This struct contains 30 fields.
+struct MyParticle {
+  bool isActive;
+  int priority;
+
+  float x, y, z;
+  float dx, dy, dz;
+  float ddx, ddy, ddz;
+  bool isCollider;
+
+  int age, maxAge;
+  float size1, size2;
+
+  bool hasColor;
+  unsigned char r1, g1, b1, a1;
+  unsigned char r2, g2, b2, a2;
+
+  class texture *tex;
+  float u1, v1, u2, v2;
+};

cpp/ql/src/Architecture/Refactoring Opportunities/FunctionsWithManyParameters.cpp

@@ -1,8 +1,8 @@
-// this example has 15 parameters.
-void fillRect(int x, int y, int w, int h,
-              int r1, int g1, int b1, int a1,
-              int r2, int g2, int b2, int a2,
-              gradient_type grad, unsigned int flags, bool border)
-{
-	// ...
-}
+// this example has 15 parameters.
+void fillRect(int x, int y, int w, int h,
+              int r1, int g1, int b1, int a1,
+              int r2, int g2, int b2, int a2,
+              gradient_type grad, unsigned int flags, bool border)
+{
+	// ...
+}

cpp/ql/src/Best Practices/ComplexCondition.cpp

@@ -1,13 +1,13 @@
-//This condition is too complex and can be improved by using local variables
-bool accept_message =
-	(message_type == CONNECT && _state != CONNECTED) ||
-	(message_type == DISCONNECT && _state == CONNECTED) ||
-	(message_type == DATA && _state == CONNECTED);
-
-//This condition is acceptable, as all the logical operators are of the same type (&&)
-bool valid_connect =
-	message_type == CONNECT && 
-	_state != CONNECTED &&
-	time_since_prev_connect > MAX_CONNECT_INTERVAL &&
-	message_length <= MAX_PACKET_SIZE &&
+//This condition is too complex and can be improved by using local variables
+bool accept_message =
+	(message_type == CONNECT && _state != CONNECTED) ||
+	(message_type == DISCONNECT && _state == CONNECTED) ||
+	(message_type == DATA && _state == CONNECTED);
+
+//This condition is acceptable, as all the logical operators are of the same type (&&)
+bool valid_connect =
+	message_type == CONNECT && 
+	_state != CONNECTED &&
+	time_since_prev_connect > MAX_CONNECT_INTERVAL &&
+	message_length <= MAX_PACKET_SIZE &&
 	checksum(message) == get_checksum_field(message);

cpp/ql/src/Best Practices/Hiding/DeclarationHidesParameter.cpp

@@ -1,6 +1,6 @@
-void f(int i) {
-  for (int i = 0; i < 10; ++i) { //the loop variable hides the parameter to f()
-    ...
-  }
-}
-
+void f(int i) {
+  for (int i = 0; i < 10; ++i) { //the loop variable hides the parameter to f()
+    ...
+  }
+}
+

cpp/ql/src/Best Practices/Hiding/DeclarationHidesVariable.cpp

@@ -1,12 +1,12 @@
-void f() {
-	int i = 10;
-
-	for (int i = 0; i < 10; i++) { //the loop counter hides the variable
-		 ...
-	}
-
-	{
-		int i = 12; //this variable hides the variable in the outer block
-		...
-	}
-}
+void f() {
+	int i = 10;
+
+	for (int i = 0; i < 10; i++) { //the loop counter hides the variable
+		 ...
+	}
+
+	{
+		int i = 12; //this variable hides the variable in the outer block
+		...
+	}
+}

cpp/ql/src/Best Practices/Hiding/LocalVariableHidesGlobalVariable.cpp

@@ -1,12 +1,12 @@
-int i = 10;
-
-void f() {
-	for (int i = 0; i < 10; i++) { //the loop counter hides the global variable i
-		 ...
-	}
-
-	{
-		int i = 12; //this variable hides the global variable i
-		...
-	}
-}
+int i = 10;
+
+void f() {
+	for (int i = 0; i < 10; i++) { //the loop counter hides the global variable i
+		 ...
+	}
+
+	{
+		int i = 12; //this variable hides the global variable i
+		...
+	}
+}

cpp/ql/src/Best Practices/Likely Errors/EmptyBlock.cpp

@@ -1,9 +1,9 @@
-void f(int i) {
-	if (i == 10); //empty then block
-		... //won't be part of the if statement
-
-	if (i == 12) {
-		...
-	} else { //empty else block, most likely a mistake
-	}
-}
+void f(int i) {
+	if (i == 10); //empty then block
+		... //won't be part of the if statement
+
+	if (i == 12) {
+		...
+	} else { //empty else block, most likely a mistake
+	}
+}

cpp/ql/src/Best Practices/Likely Errors/Slicing.cpp

@@ -1,43 +1,43 @@
-static int idctr = 0;
-//Basic connection with id
-class Connection {
-public:
-    int connId;
-    virtual void print_info() {
-        cout << "id: " << connId << "\n";
-    }
-    Connection() {
-        connId = idctr++;
-    }
-};
-
-//Adds counters, and an overriding print_info
-class MeteredConnection : public Connection {
-public:
-    int txCtr;
-    int rxCtr;
-    MeteredConnection() {
-        txCtr = 0;
-        rxCtr = 0;
-    }
-    virtual void print_info() {
-        cout << "id: " << connId << "\n" << "tx/rx: " << txCtr << "/" << rxCtr << "\n";
-    }
-};
-
-int main(int argc, char* argv[]) {
-    Connection conn;
-    MeteredConnection m_conn;
-
-    Connection curr_conn = conn;
-    curr_conn.print_info();
-    curr_conn = m_conn; //Wrong: Derived MetricConnection assigned to Connection 
-                        //variable, will slice off the counters and the overriding print_info
-    curr_conn.print_info(); //Will not print the counters.
-
-    Connection* curr_pconn = &conn;
-    curr_pconn->print_info();
-    curr_pconn = &m_conn; //Correct: Pointer assigned to address of the MetricConnection. 
-                          //Counters and virtual functions remain intact.
-    curr_pconn->print_info(); //Will call the correct method MeteredConnection::print_info
-}
+static int idctr = 0;
+//Basic connection with id
+class Connection {
+public:
+    int connId;
+    virtual void print_info() {
+        cout << "id: " << connId << "\n";
+    }
+    Connection() {
+        connId = idctr++;
+    }
+};
+
+//Adds counters, and an overriding print_info
+class MeteredConnection : public Connection {
+public:
+    int txCtr;
+    int rxCtr;
+    MeteredConnection() {
+        txCtr = 0;
+        rxCtr = 0;
+    }
+    virtual void print_info() {
+        cout << "id: " << connId << "\n" << "tx/rx: " << txCtr << "/" << rxCtr << "\n";
+    }
+};
+
+int main(int argc, char* argv[]) {
+    Connection conn;
+    MeteredConnection m_conn;
+
+    Connection curr_conn = conn;
+    curr_conn.print_info();
+    curr_conn = m_conn; //Wrong: Derived MetricConnection assigned to Connection 
+                        //variable, will slice off the counters and the overriding print_info
+    curr_conn.print_info(); //Will not print the counters.
+
+    Connection* curr_pconn = &conn;
+    curr_pconn->print_info();
+    curr_pconn = &m_conn; //Correct: Pointer assigned to address of the MetricConnection. 
+                          //Counters and virtual functions remain intact.
+    curr_pconn->print_info(); //Will call the correct method MeteredConnection::print_info
+}

cpp/ql/src/Best Practices/Magic Constants/MagicConstantsNumbers.cpp

@@ -1,16 +1,16 @@
-void sanitize(Fields[] record) {
-    //The number of fields here can be put in a const
-	for (fieldCtr = 0; field < 7; field++) {
-		sanitize(fields[fieldCtr]);
-	}
-}
-
-#define NUM_FIELDS 7
-
-void process(Fields[] record) {
-	//This avoids using a magic constant by using the macro instead
-	for (fieldCtr = 0; field < NUM_FIELDS; field++) {
-		process(fields[fieldCtr]);
-	}
-}
-
+void sanitize(Fields[] record) {
+    //The number of fields here can be put in a const
+	for (fieldCtr = 0; field < 7; field++) {
+		sanitize(fields[fieldCtr]);
+	}
+}
+
+#define NUM_FIELDS 7
+
+void process(Fields[] record) {
+	//This avoids using a magic constant by using the macro instead
+	for (fieldCtr = 0; field < NUM_FIELDS; field++) {
+		process(fields[fieldCtr]);
+	}
+}
+

cpp/ql/src/Best Practices/RuleOfTwo.cpp

@@ -1,26 +1,26 @@
-class C {
-private:
-	Other* other = NULL;
-public:
-	C(const C& copyFrom) {
-		Other* newOther = new Other();
-		*newOther = copyFrom.other;
-		this->other = newOther;
-	}
-
-	//No operator=, by default will just copy the pointer other, will not create a new object
-};
-
-class D {
-	Other* other = NULL;
-public:
-	D& operator=(D& rhs) {
-		Other* newOther = new Other();
-		*newOther = rhs.other;
-		this->other = newOther;
-		return *this;
-	}
-
-	//No copy constructor, will just copy the pointer other and not create a new object
-};
-
+class C {
+private:
+	Other* other = NULL;
+public:
+	C(const C& copyFrom) {
+		Other* newOther = new Other();
+		*newOther = copyFrom.other;
+		this->other = newOther;
+	}
+
+	//No operator=, by default will just copy the pointer other, will not create a new object
+};
+
+class D {
+	Other* other = NULL;
+public:
+	D& operator=(D& rhs) {
+		Other* newOther = new Other();
+		*newOther = rhs.other;
+		this->other = newOther;
+		return *this;
+	}
+
+	//No copy constructor, will just copy the pointer other and not create a new object
+};
+