Making argv filter positional.

bdrodes · bdrodes · commit 8d35db0fe63a · 2024-02-21T12:25:35.000-05:00
diff --git a/cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql b/cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
@@ -72,7 +72,7 @@ predicate isNonConst(DataFlow::Node node) {
     p = node.asParameter() and
     // Ignore main's argv parameter as it is already considered a `FlowSource`
     // not ignoring it will result in path redundancies
-    (f.getName() = "main" implies p.getName() != "argv")
+    (f.getName() = "main" implies p != f.getParameter(1))
   )
   or
   // Consider as an input any out arg of a function or a function's return where the function is not:

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ predicate isNonConst(DataFlow::Node node) {`
`72`	`72`	`p = node.asParameter() and`
`73`	`73`	// Ignore main's argv parameter as it is already considered a `FlowSource`
`74`	`74`	`// not ignoring it will result in path redundancies`
`75`		`- (f.getName() = "main" implies p.getName() != "argv")`
	`75`	`+ (f.getName() = "main" implies p != f.getParameter(1))`
`76`	`76`	`)`
`77`	`77`	`or`
`78`	`78`	`// Consider as an input any out arg of a function or a function's return where the function is not:`