Also follow jump steps when looking for a callee source

owen-mc · owen-mc · commit 40b3598fd02f · 2023-12-08T18:44:14.000Z
This is needed because capturing a variable is a jump step
and we want to find a callee source for captured functions.
diff --git a/go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll b/go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
@@ -473,6 +473,7 @@ module Public {
   private DataFlow::Node getACalleeSource(DataFlow::CallNode cn) {
     result = cn.getCalleeNode() or
     basicLocalFlowStep(result, getACalleeSource(cn)) or
+    jumpStep(result, getACalleeSource(cn)) or
     result.asExpr() = getACalleeSource(cn).asExpr().(GenericFunctionInstantiationExpr).getBase()
   }
 

Original file line number	Diff line number	Diff line change
`@@ -473,6 +473,7 @@ module Public {`
`473`	`473`	`private DataFlow::Node getACalleeSource(DataFlow::CallNode cn) {`
`474`	`474`	`result = cn.getCalleeNode() or`
`475`	`475`	`basicLocalFlowStep(result, getACalleeSource(cn)) or`
	`476`	`+ jumpStep(result, getACalleeSource(cn)) or`
`476`	`477`	`result.asExpr() = getACalleeSource(cn).asExpr().(GenericFunctionInstantiationExpr).getBase()`
`477`	`478`	`}`
`478`	`479`