Skip to content

Commit 310eec0

Browse files
committed
Java/Python: Fix some potential performance problems due to transitive deltas.
1 parent 8b6baa2 commit 310eec0

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

java/ql/lib/semmle/code/java/frameworks/Rmi.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ class RemoteCallableMethod extends Method {
1414
private predicate remoteCallableMethod(Method method) {
1515
method.getDeclaringType().getASupertype() instanceof TypeRemote
1616
or
17-
exists(Method meth | remoteCallableMethod(meth) and method.getAnOverride() = meth)
17+
exists(Method meth | remoteCallableMethod(meth) and method.overrides(meth))
1818
}

python/ql/lib/semmle/python/Exprs.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class Expr extends Expr_, AstNode {
1717
* Whether this expression defines variable `v`
1818
* If doing dataflow, then consider using SsaVariable.getDefinition() for more precision.
1919
*/
20-
predicate defines(Variable v) { this.getASubExpression+().defines(v) }
20+
predicate defines(Variable v) { this.getASubExpression().defines(v) }
2121

2222
/** Whether this expression may have a side effect (as determined purely from its syntax) */
2323
predicate hasSideEffects() {

python/ql/lib/semmle/python/pointsto/PointsTo.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ module PointsToInternal {
300300
ssa_definition_points_to(var.getDefinition(), context, value, origin)
301301
or
302302
exists(EssaVariable prev |
303-
ssaShortCut+(prev, var) and
303+
ssaShortCut(prev, var) and
304304
variablePointsTo(prev, context, value, origin)
305305
)
306306
}

0 commit comments

Comments
 (0)