Skip to content

Commit 112caa3

Browse files
committed
rewrite qldoc based on review
1 parent 34e7589 commit 112caa3

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

javascript/ql/lib/semmle/javascript/dataflow/TaintTracking.qll

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1126,9 +1126,7 @@ module TaintTracking {
11261126
)
11271127
}
11281128

1129-
/**
1130-
* Holds if `test` is of the form `typeof x === "something"`, preventing `x` from being a string in some cases.
1131-
*/
1129+
/** A test for the value of `typeof x`, restricting the potential types of `x`. */
11321130
predicate isStringTypeGuard(EqualityTest test, Expr operand, boolean polarity) {
11331131
exists(TypeofTag tag | TaintTracking::isTypeofGuard(test, operand, tag) |
11341132
// typeof x === "string" sanitizes `x` when it evaluates to false

javascript/ql/lib/semmle/javascript/security/dataflow/UnsafeHtmlConstructionCustomizations.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ module UnsafeHtmlConstruction {
181181
override string describe() { result = "Markdown rendering" }
182182
}
183183

184-
/** A test of form `typeof x === "something"`, preventing `x` from being a string in some cases. */
184+
/** A test for the value of `typeof x`, restricting the potential types of `x`. */
185185
class TypeTestGuard extends TaintTracking::SanitizerGuardNode, DataFlow::ValueNode {
186186
override EqualityTest astNode;
187187
Expr operand;

javascript/ql/lib/semmle/javascript/security/dataflow/XssThroughDomQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class Configuration extends TaintTracking::Configuration {
5151
}
5252
}
5353

54-
/** A test of form `typeof x === "something"`, preventing `x` from being a string in some cases. */
54+
/** A test for the value of `typeof x`, restricting the potential types of `x`. */
5555
class TypeTestGuard extends TaintTracking::SanitizerGuardNode, DataFlow::ValueNode {
5656
override EqualityTest astNode;
5757
Expr operand;

0 commit comments

Comments
 (0)