Skip to content

Commit eefb943

Browse files
committed
Don't use Zstandard bundles on Windows
In testing, gzip performs better than Zstandard on Windows.
1 parent 9d1e406 commit eefb943

File tree

7 files changed

+7
-8
lines changed

7 files changed

+7
-8
lines changed

.github/workflows/__zstd-bundle-fallback.yml

-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__zstd-bundle.yml

-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/setup-codeql.js

+4-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/setup-codeql.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pr-checks/checks/zstd-bundle-fallback.yml

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ versions:
44
- linked
55
operatingSystems:
66
- macos
7-
- windows
87
- ubuntu
98
env:
109
CODEQL_ACTION_ZSTD_BUNDLE: true

pr-checks/checks/zstd-bundle.yml

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ versions:
44
- linked
55
operatingSystems:
66
- macos
7-
- windows
87
- ubuntu
98
env:
109
CODEQL_ACTION_ZSTD_BUNDLE: true

src/setup-codeql.ts

+2
Original file line numberDiff line numberDiff line change
@@ -823,6 +823,8 @@ async function useZstdBundle(
823823
tarSupportsZstd: boolean,
824824
): Promise<boolean> {
825825
return (
826+
// In testing, gzip performs better than zstd on Windows.
827+
process.platform !== "win32" &&
826828
tarSupportsZstd &&
827829
semver.gte(cliVersion, CODEQL_VERSION_ZSTD_BUNDLE) &&
828830
!!(await features.getValue(Feature.ZstdBundle))

0 commit comments

Comments
 (0)