Skip to content

Commit acb9cb1

Browse files
authored
Merge pull request #2577 from github/aeisenberg/macos-13-runners
Move to macos-13 runners
2 parents 3821acc + faa9634 commit acb9cb1

8 files changed

+22
-15
lines changed

.github/workflows/__go-tracing-autobuilder.yml

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__go-tracing-custom-build-steps.yml

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__go-tracing-legacy-workflow.yml

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__multi-language-autodetect.yml

+9-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/codeql.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ jobs:
7575
strategy:
7676
fail-fast: false
7777
matrix:
78-
os: [ubuntu-20.04,ubuntu-22.04,windows-2019,windows-2022,macos-12,macos-13,macos-14]
78+
os: [ubuntu-20.04,ubuntu-22.04,windows-2019,windows-2022,macos-13,macos-14]
7979
tools: ${{ fromJson(needs.check-codeql-versions.outputs.versions) }}
8080
runs-on: ${{ matrix.os }}
8181

pr-checks/checks/multi-language-autodetect.yml

+6-4
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,13 @@ steps:
1010
id: init
1111
with:
1212
db-location: "${{ runner.temp }}/customDbLocation"
13-
# Swift is not supported on Ubuntu so we manually exclude it from the list here
14-
languages: ${{ runner.os == 'Linux' && 'cpp,csharp,go,java,javascript,python,ruby' || '' }}
13+
# Swift is not supported on Ubuntu or codeql 2.14 so we manually exclude it from the list here
14+
languages: ${{ (runner.os == 'Linux' || (runner.os == 'macOS' && matrix.version == 'stable-v2.14.6')) && 'cpp,csharp,go,java,javascript,python,ruby' || '' }}
1515
tools: ${{ steps.prepare-test.outputs.tools-url }}
1616

1717
- uses: ./../action/.github/actions/setup-swift
18-
if: runner.os == 'macOS'
18+
# Exclude macos on v2.14.6 since we can not longer run swift on ARM runners
19+
if: runner.os == 'macOS' && matrix.version != 'stable-v2.14.6'
1920
with:
2021
codeql-path: ${{ steps.init.outputs.codeql-path }}
2122

@@ -68,7 +69,8 @@ steps:
6869
fi
6970
7071
- name: Check language autodetect for Swift on macOS
71-
if: runner.os == 'macOS'
72+
# Exclude macos on v2.14.6 since we can not longer run swift on ARM runners
73+
if: runner.os == 'macOS' && matrix.version != 'stable-v2.14.6'
7274
shell: bash
7375
run: |
7476
SWIFT_DB=${{ fromJson(steps.analysis.outputs.db-locations).swift }}

pr-checks/sync.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def writeHeader(checkStream):
8484
# "macos-latest" is now an ARM runner, so we run tests on the old CLIs on Intel runners instead.
8585
if version in ["stable-v2.14.6"] and runnerImage == "macos-latest":
8686
matrix.append({
87-
'os': "macos-12",
87+
'os': "macos-13",
8888
'version': version
8989
})
9090
else:

tests/multi-language-repo/build.sh

+2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ javac Main.java
88

99
go build main.go
1010

11+
# Not all platforms support Swift
1112
if [[ "$OSTYPE" == "darwin"* ]]; then
13+
echo "Compiling Swift"
1214
swift build
1315
fi
1416

0 commit comments

Comments
 (0)