Skip to content

Commit 9632771

Browse files
committed
Address review comments
1 parent d427c89 commit 9632771

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

queries/default-setup-event-context.ql

+4-8
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ class EventContextAccessConfiguration extends DataFlow::Configuration {
2727
override predicate isSink(DataFlow::Node sink, DataFlow::FlowLabel lbl) {
2828
sink instanceof DataFlow::PropRead and
2929
lbl instanceof ParsedLabel and
30-
not exists(DataFlow::PropRead n | sink = n.getBase())
30+
not exists(DataFlow::PropRead n | sink = n.getBase()) and
31+
not sink.asExpr().getFile().getBaseName().matches("%.test.ts")
3132
}
3233

3334
override predicate isAdditionalFlowStep(
@@ -52,11 +53,6 @@ class EventContextAccessConfiguration extends DataFlow::Configuration {
5253
}
5354

5455
from EventContextAccessConfiguration cfg, DataFlow::PathNode source, DataFlow::PathNode sink
55-
where
56-
cfg.hasFlowPath(source, sink) and
57-
not sink.getNode().asExpr().getFile().getBaseName().matches("%.test.ts")
56+
where cfg.hasFlowPath(source, sink)
5857
select sink.getNode(), source, sink,
59-
"This context property may not exist in default setup workflows. If all uses are safe, add it to the list of "
60-
+ "context properties that are known to be safe in " +
61-
"'queries/default-setup-event-context.ql'. If this use is safe but others are not, " +
62-
"dismiss this alert as a false positive."
58+
"This event context property may not exist in default setup workflows."

0 commit comments

Comments
 (0)