Skip to content

Commit 81b8143

Browse files
authored
Merge pull request #2330 from github/aeisenberg/force-overwrite
Use `--force-overwrite` for creating databases
2 parents c796494 + eb1d92b commit 81b8143

7 files changed

+17
-5
lines changed

Diff for: CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the
66

77
## [UNRELEASED]
88

9-
No user facing changes.
9+
- Avoid failing database creation if the database folder already exists and contains some unexpected files. [#2330](https://github.com/github/codeql-action/pull/2330)
1010

1111
## 3.25.8 - 04 Jun 2024
1212

Diff for: lib/codeql.js

+4-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: lib/codeql.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: lib/tools-features.js

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: lib/tools-features.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: src/codeql.ts

+8-1
Original file line numberDiff line numberDiff line change
@@ -612,12 +612,19 @@ export async function getCodeQLForCmd(
612612
extraArgs.push("--no-sublanguage-file-coverage");
613613
}
614614

615+
const overwriteFlag = isSupportedToolsFeature(
616+
await this.getVersion(),
617+
ToolsFeature.ForceOverwrite,
618+
)
619+
? "--force-overwrite"
620+
: "--overwrite";
621+
615622
await runTool(
616623
cmd,
617624
[
618625
"database",
619626
"init",
620-
"--overwrite",
627+
overwriteFlag,
621628
"--db-cluster",
622629
config.dbLocation,
623630
`--source-root=${sourceRoot}`,

Diff for: src/tools-features.ts

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export enum ToolsFeature {
88
SetsCodeqlRunnerEnvVar = "setsCodeqlRunnerEnvVar",
99
TraceCommandUseBuildMode = "traceCommandUseBuildMode",
1010
SarifMergeRunsFromEqualCategory = "sarifMergeRunsFromEqualCategory",
11+
ForceOverwrite = "forceOverwrite",
1112
}
1213

1314
/**

0 commit comments

Comments
 (0)