Skip to content

Commit 7c35b4f

Browse files
committed
Rename for clarity per PR review
1 parent 462c756 commit 7c35b4f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Diff for: pr-checks/sync.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"nightly-latest"
2828
]
2929

30-
def is_version_and_os_excluded(version, os, exclude_params):
30+
def is_os_and_version_excluded(version, os, exclude_params):
3131
for exclude_param in exclude_params:
3232
if exclude_param[0] == os and exclude_param[1] == version:
3333
return True
@@ -63,7 +63,7 @@ def writeHeader(checkStream):
6363
with open(file, 'r') as checkStream:
6464
checkSpecification = yaml.load(checkStream)
6565
matrix = []
66-
excludedVersionsAndOses = checkSpecification.get('excludeOsAndVersionCombination', [])
66+
excludedOsesAndVersions = checkSpecification.get('excludeOsAndVersionCombination', [])
6767
for version in checkSpecification.get('versions', defaultTestVersions):
6868
runnerImages = ["ubuntu-latest", "macos-latest", "windows-latest"]
6969
operatingSystems = checkSpecification.get('operatingSystems', ["ubuntu", "macos", "windows"])
@@ -73,7 +73,7 @@ def writeHeader(checkStream):
7373

7474
for runnerImage in runnerImagesForOs:
7575
# Skip appending this combination to the matrix if it is explicitly excluded.
76-
if is_version_and_os_excluded(version, operatingSystem, excludedVersionsAndOses):
76+
if is_os_and_version_excluded(version, operatingSystem, excludedOsesAndVersions):
7777
continue
7878

7979
# Prior to CLI v2.15.1, ARM runners were not supported by the build tracer.

0 commit comments

Comments
 (0)