Skip to content

Commit 76622e7

Browse files
committed
Merge branch 'main' into marcogario/skip_proxy
2 parents 8aa028b + 5f4f998 commit 76622e7

9 files changed

+10
-37
lines changed

.github/workflows/post-release-mergeback.yml

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929

3030
permissions:
3131
contents: write # needed to create tags and push commits
32+
pull-requests: write
3233

3334
steps:
3435
- name: Dump environment

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ See the [releases page](https://github.com/github/codeql-action/releases) for th
44

55
## [UNRELEASED]
66

7+
No user facing changes.
8+
9+
## 3.28.6 - 27 Jan 2025
10+
711
- Re-enable debug artifact upload for CLI versions 2.20.3 or greater. [#2726](https://github.com/github/codeql-action/pull/2726)
812

913
## 3.28.5 - 24 Jan 2025

lib/start-proxy-action.js

-14
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/start-proxy-action.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

node_modules/.package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "codeql",
3-
"version": "3.28.6",
3+
"version": "3.28.7",
44
"private": true,
55
"description": "CodeQL action",
66
"scripts": {

src/start-proxy-action.ts

-15
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ const UPDATEJOB_PROXY = "update-job-proxy";
1414
const UPDATEJOB_PROXY_VERSION = "v2.0.20241023203727";
1515
const UPDATEJOB_PROXY_URL_PREFIX =
1616
"https://github.com/github/codeql-action/releases/download/codeql-bundle-v2.18.1/";
17-
const PROXY_USER = "proxy_user";
1817
const KEY_SIZE = 2048;
1918
const KEY_EXPIRY_YEARS = 2;
2019

@@ -113,12 +112,10 @@ async function runWrapper() {
113112
);
114113

115114
const ca = generateCertificateAuthority();
116-
const proxyAuth = getProxyAuth();
117115

118116
const proxyConfig: ProxyConfig = {
119117
all_credentials: credentials,
120118
ca,
121-
proxy_auth: proxyAuth,
122119
};
123120

124121
// Start the Proxy
@@ -187,18 +184,6 @@ async function startProxy(
187184
}
188185
}
189186

190-
// getProxyAuth returns the authentication information for the proxy itself.
191-
function getProxyAuth(): BasicAuthCredentials | undefined {
192-
const proxy_password = actionsUtil.getOptionalInput("proxy_password");
193-
if (proxy_password) {
194-
return {
195-
username: PROXY_USER,
196-
password: proxy_password,
197-
};
198-
}
199-
return;
200-
}
201-
202187
async function getProxyBinaryPath(): Promise<string> {
203188
const proxyFileName =
204189
process.platform === "win32" ? `${UPDATEJOB_PROXY}.exe` : UPDATEJOB_PROXY;

start-proxy/action.yml

-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ inputs:
99
registries_credentials:
1010
description: Base64 encoded JSON configuration for the URLs and credentials of the package registries
1111
required: false
12-
proxy_password:
13-
required: false
14-
description: The password of the proxy
1512
token:
1613
description: GitHub token to use for authenticating with this instance of GitHub, used to upload debug artifacts.
1714
default: ${{ github.token }}

0 commit comments

Comments
 (0)