Merge pull request #2349 from github/aeisenberg/no-fail-upload-artifacts

Author: aeisenberg

Diff for: CHANGELOG.md

@@ -6,7 +6,7 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the
 
 ## [UNRELEASED]
 
-No user facing changes.
+- Avoid failing the workflow run if there is an error while uploading debug artifacts. [#2349](https://github.com/github/codeql-action/pull/2349)
 
 ## 3.25.10 - 13 Jun 2024
 

Diff for: lib/debug-artifacts.js

@@ -45,16 +45,22 @@ export async function uploadDebugArtifacts(
       );
     }
   }
-  await artifact.create().uploadArtifact(
-    sanitizeArifactName(`${artifactName}${suffix}`),
-    toUpload.map((file) => path.normalize(file)),
-    path.normalize(rootDir),
-    {
-      continueOnError: true,
-      // ensure we don't keep the debug artifacts around for too long since they can be large.
-      retentionDays: 7,
-    },
-  );
+
+  try {
+    await artifact.create().uploadArtifact(
+      sanitizeArifactName(`${artifactName}${suffix}`),
+      toUpload.map((file) => path.normalize(file)),
+      path.normalize(rootDir),
+      {
+        continueOnError: true,
+        // ensure we don't keep the debug artifacts around for too long since they can be large.
+        retentionDays: 7,
+      },
+    );
+  } catch (e) {
+    // A failure to upload debug artifacts should not fail the entire action.
+    core.warning(`Failed to upload debug artifacts: ${e}`);
+  }
 }
 
 export async function uploadSarifDebugArtifact(