Skip to content

Commit 2bab9f7

Browse files
committed
Ensure artifacts are only uploaded in safe situations
This commit: Turns on uploading of artifacts again but only if CLI version is >= 2.20.3. I implemented the check using our feature flag functionality. I was on the fence about this since it makes the PR more complex. However, it does give us more flexibility when controlling artifact uploads. Also, I renamed the two workflows that were previously disabled. This way we will not accidentally enable the old workflows for previous versions of the action.
1 parent e7c0c9d commit 2bab9f7

17 files changed

+264
-39
lines changed

.github/workflows/debug-artifacts-failure.yml renamed to .github/workflows/debug-artifacts-failure-safe.yml

+9-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,14 @@ on:
1919
workflow_dispatch: {}
2020
jobs:
2121
upload-artifacts:
22+
strategy:
23+
fail-fast: false
24+
matrix:
25+
version:
26+
- stable-v2.20.3
27+
- default
28+
- linked
29+
- nightly-latest
2230
name: Upload debug artifacts after failure in analyze
2331
continue-on-error: true
2432
env:
@@ -36,7 +44,7 @@ jobs:
3644
id: prepare-test
3745
uses: ./.github/actions/prepare-test
3846
with:
39-
version: linked
47+
version: ${{ matrix.version }}
4048
- uses: actions/setup-go@v5
4149
with:
4250
go-version: ^1.13.1

.github/workflows/debug-artifacts.yml renamed to .github/workflows/debug-artifacts-safe.yml

+1-5
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,7 @@ jobs:
2222
fail-fast: false
2323
matrix:
2424
version:
25-
- stable-v2.15.5
26-
- stable-v2.16.6
27-
- stable-v2.17.6
28-
- stable-v2.18.4
29-
- stable-v2.19.4
25+
- stable-v2.20.3
3026
- default
3127
- linked
3228
- nightly-latest

lib/analyze-action-post.js

+9-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/analyze-action-post.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/debug-artifacts.js

+17-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)