Skip to content

Commit 048b0a2

Browse files
committed
Remove Node 16 compilation PR check
1 parent 3b4f4d9 commit 048b0a2

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

.github/workflows/pr-checks.yml

-26
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ jobs:
1919

2020
strategy:
2121
fail-fast: false
22-
matrix:
23-
node-types-version: [16.11, current] # run tests on 16.11 while CodeQL Action v2 is still supported
2422

2523
steps:
2624
- name: Checkout
@@ -32,34 +30,10 @@ jobs:
3230

3331
- name: Upload sarif
3432
uses: github/codeql-action/upload-sarif@v3
35-
# Only upload SARIF for the latest version of Node.js
36-
if: "!cancelled() && matrix.node-types-version == 'current' && !startsWith(github.head_ref, 'dependabot/')"
3733
with:
3834
sarif_file: eslint.sarif
3935
category: eslint
4036

41-
- name: Update version of @types/node
42-
if: matrix.node-types-version != 'current'
43-
env:
44-
NODE_TYPES_VERSION: ${{ matrix.node-types-version }}
45-
run: |
46-
# Export `NODE_TYPES_VERSION` so it's available to jq
47-
export NODE_TYPES_VERSION="${NODE_TYPES_VERSION}"
48-
contents=$(jq '.devDependencies."@types/node" = env.NODE_TYPES_VERSION' package.json)
49-
echo "${contents}" > package.json
50-
# Usually we run `npm install` on macOS to ensure that we pick up macOS-only dependencies.
51-
# However we're not checking in the updated lockfile here, so it's fine to run
52-
# `npm install` on Linux.
53-
npm install
54-
55-
if [ ! -z "$(git status --porcelain)" ]; then
56-
git config --global user.email "[email protected]"
57-
git config --global user.name "github-actions[bot]"
58-
# The period in `git add --all .` ensures that we stage deleted files too.
59-
git add --all .
60-
git commit -m "Use @types/node=${NODE_TYPES_VERSION}"
61-
fi
62-
6337
- name: Check generated JS
6438
run: .github/workflows/script/check-js.sh
6539

0 commit comments

Comments
 (0)