Skip to content
This repository was archived by the owner on Oct 21, 2021. It is now read-only.

Add this behavior to Babel #11

Open
robdodson opened this issue Nov 3, 2017 · 8 comments
Open

Add this behavior to Babel #11

robdodson opened this issue Nov 3, 2017 · 8 comments

Comments

@robdodson
Copy link

I spoke with @hzoo at the recent Chrome Dev Summit afterparty about this issue, and we discussed updating the behavior in Babel to call Reflect.construct when extending exotic things like HTMLElement.

I was wondering if the maintainers of this project would be interested in helping put together a PR to explore updating Babel's behavior?

cc @owencm @justinfagnani

@owencm
Copy link

owencm commented Nov 3, 2017

FWIW, I strongly support this as a way to fix facebook/create-react-app#3225

@treshugart
Copy link

treshugart commented Nov 5, 2017

It may just be me but, I've never actually been able to get this plugin to work.

@robdodson
Copy link
Author

@treshugart I put together a simple vanilla element and example and it seems to be working OK. Do you happen to have a reproducible test case where it breaks?

@josh
Copy link
Contributor

josh commented Dec 12, 2017

Would love to deprecate this repository if this feature is upstreamed.

@robdodson
Copy link
Author

is anyone familiar enough with the Babel codebase to do the upstreaming work...? 😁
cc @justinfagnani, @FredKSchott

@hzoo
Copy link

hzoo commented Dec 12, 2017

Can do a call to go over things if it's helpful. babel/babel#4480 (comment) some people are really excited for this kind of thing + https://github.com/WebReflection/babel-plugin-transform-builtin-classes

Ok @nicolo-ribaudo started a PR so maybe everyone can help review if it covers the same behavior as this plugin. babel/babel#7020

@treshugart
Copy link

Hey @robdodson, I think I was just being a dummy. I was using it on the consuming end as opposed to building Skate with it (IIRC). See comment here. Looks like there's plans for this to go into Skate as well.

@nicolo-ribaudo
Copy link

Hi everyone,
Can someone confirm if the behavior of this plugin is covered by babel/babel#7020 or not?
I don't want to block that PR on this, but I can look to port this plugin in @babel/plugin-transform-classes if the other Babel team members agree.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants