-
Notifications
You must be signed in to change notification settings - Fork 12
Add this behavior to Babel #11
Comments
FWIW, I strongly support this as a way to fix facebook/create-react-app#3225 |
It may just be me but, I've never actually been able to get this plugin to work. |
@treshugart I put together a simple vanilla element and example and it seems to be working OK. Do you happen to have a reproducible test case where it breaks? |
Would love to deprecate this repository if this feature is upstreamed. |
is anyone familiar enough with the Babel codebase to do the upstreaming work...? 😁 |
Can do a call to go over things if it's helpful. babel/babel#4480 (comment) some people are really excited for this kind of thing + https://github.com/WebReflection/babel-plugin-transform-builtin-classes Ok @nicolo-ribaudo started a PR so maybe everyone can help review if it covers the same behavior as this plugin. babel/babel#7020 |
Hey @robdodson, I think I was just being a dummy. I was using it on the consuming end as opposed to building Skate with it (IIRC). See comment here. Looks like there's plans for this to go into Skate as well. |
Hi everyone, |
I spoke with @hzoo at the recent Chrome Dev Summit afterparty about this issue, and we discussed updating the behavior in Babel to call
Reflect.construct
when extending exotic things like HTMLElement.I was wondering if the maintainers of this project would be interested in helping put together a PR to explore updating Babel's behavior?
cc @owencm @justinfagnani
The text was updated successfully, but these errors were encountered: