From 611cdfeba03dd152d97e47665e601bcf25833636 Mon Sep 17 00:00:00 2001 From: Stuart Pearson <1926002+stuartp44@users.noreply.github.com> Date: Wed, 18 Dec 2024 15:57:25 +0100 Subject: [PATCH 1/3] Added debug for queued events function --- .../functions/control-plane/src/scale-runners/scale-up.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lambdas/functions/control-plane/src/scale-runners/scale-up.ts b/lambdas/functions/control-plane/src/scale-runners/scale-up.ts index c21aa4c2f1..c386c05257 100644 --- a/lambdas/functions/control-plane/src/scale-runners/scale-up.ts +++ b/lambdas/functions/control-plane/src/scale-runners/scale-up.ts @@ -148,6 +148,12 @@ export async function isJobQueued(githubInstallationClient: Octokit, payload: Ac }); metricGitHubAppRateLimit(jobForWorkflowRun.headers); isQueued = jobForWorkflowRun.data.status === 'queued'; + if (!isQueued) { + logger.info(`Job ${payload.id} is not queued`); + } + else { + logger.info(`Job ${payload.id} is queued`); + } } else { throw Error(`Event ${payload.eventType} is not supported`); } From fcea1c7d9e39f91915af35949db6f79a61a32f3e Mon Sep 17 00:00:00 2001 From: Stuart Pearson <1926002+stuartp44@users.noreply.github.com> Date: Wed, 18 Dec 2024 16:57:56 +0100 Subject: [PATCH 2/3] Actioned feedback --- .../functions/control-plane/src/scale-runners/scale-up.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lambdas/functions/control-plane/src/scale-runners/scale-up.ts b/lambdas/functions/control-plane/src/scale-runners/scale-up.ts index c386c05257..b5647fa3be 100644 --- a/lambdas/functions/control-plane/src/scale-runners/scale-up.ts +++ b/lambdas/functions/control-plane/src/scale-runners/scale-up.ts @@ -148,12 +148,7 @@ export async function isJobQueued(githubInstallationClient: Octokit, payload: Ac }); metricGitHubAppRateLimit(jobForWorkflowRun.headers); isQueued = jobForWorkflowRun.data.status === 'queued'; - if (!isQueued) { - logger.info(`Job ${payload.id} is not queued`); - } - else { - logger.info(`Job ${payload.id} is queued`); - } + logger.debug(`The job ${payload.id} is${isQueued ? " " : "not"} queued`); } else { throw Error(`Event ${payload.eventType} is not supported`); } From eccf40a2722544497bdcc39774b4d2963d943fb2 Mon Sep 17 00:00:00 2001 From: Stuart Pearson <1926002+stuartp44@users.noreply.github.com> Date: Wed, 18 Dec 2024 17:02:41 +0100 Subject: [PATCH 3/3] changed " to ' --- lambdas/functions/control-plane/src/scale-runners/scale-up.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lambdas/functions/control-plane/src/scale-runners/scale-up.ts b/lambdas/functions/control-plane/src/scale-runners/scale-up.ts index b5647fa3be..9b00af3e48 100644 --- a/lambdas/functions/control-plane/src/scale-runners/scale-up.ts +++ b/lambdas/functions/control-plane/src/scale-runners/scale-up.ts @@ -148,7 +148,7 @@ export async function isJobQueued(githubInstallationClient: Octokit, payload: Ac }); metricGitHubAppRateLimit(jobForWorkflowRun.headers); isQueued = jobForWorkflowRun.data.status === 'queued'; - logger.debug(`The job ${payload.id} is${isQueued ? " " : "not"} queued`); + logger.debug(`The job ${payload.id} is${isQueued ? ' ' : 'not'} queued`); } else { throw Error(`Event ${payload.eventType} is not supported`); }