We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plaintext webhook secret is not present in the terraform logs. Example
# null_resource.update_app will be created + resource "null_resource" "update_app" { + id = (known after apply) + triggers = { + "webhook_endpoint" = "https://xxxxxxxxx.execute-api.eu-central-1.amazonaws.com/webhook" + "webhook_secret" = (sensitive value) } }
Plaintext webhook secret is printed out in the terraform logs. Example
# null_resource.update_app will be created + resource "null_resource" "update_app" { + id = (known after apply) + triggers = { + "webhook_endpoint" = "https://xxxxxxxxx.execute-api.eu-central-1.amazonaws.com/webhook" + "webhook_secret" = "not_so_secret" } }
Module version: 5.12.2
5.12.2
It should be enough to mark the github_app variable as sensitive in modules/webhook-github-app/variables.tf
github_app
The text was updated successfully, but these errors were encountered:
08be669
Successfully merging a pull request may close this issue.
Expected Behavior
Plaintext webhook secret is not present in the terraform logs. Example
Current Behavior
Plaintext webhook secret is printed out in the terraform logs. Example
Module version:
5.12.2
Possible Solution
It should be enough to mark the
github_app
variable as sensitive in modules/webhook-github-app/variables.tfThe text was updated successfully, but these errors were encountered: