Skip to content

Multi-Runner Input Names are Different than Normal Runner Inputs #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srilman opened this issue Jan 25, 2024 · 4 comments
Closed

Multi-Runner Input Names are Different than Normal Runner Inputs #3740

srilman opened this issue Jan 25, 2024 · 4 comments

Comments

@srilman
Copy link

srilman commented Jan 25, 2024

When I migrated a setup using the normal runner module to the multi-runner module, I had some trouble getting it working because some of the input names differ. It would be helpful is we rename the multi-runner inputs so they are consistent. Here are some examples:

  • enable_fifo_build_queue to fifo
  • enable_runner_on_demand_failover_for_errors to enable_on_demand_failover_for_errors

There may be more, but I didn't check yet. Happy to open a PR to rename these, but want to make sure there isn't a reason why they're supposed to be different.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Feb 25, 2024
@rvodden
Copy link

rvodden commented Mar 1, 2024

Not stale. I'm happy to submit a PR

Copy link
Contributor

github-actions bot commented Apr 1, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Apr 1, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
@rvodden
Copy link

rvodden commented Apr 12, 2024

This hasn't been abandoned. I'm waiting for PlCI to be approved on the above PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants