ci: refactor terraform validation

Author: npalm

.github/workflows/terraform-validate-template.yml

@@ -49,19 +49,29 @@ jobs:
       - name: Initialize Terraform
         run: terraform init -get -backend=false -input=false
       - name: Check Terraform formatting
-        run: terraform fmt -check=true -write=false
+        run: terraform fmt -recursive -check=true -write=false
+      - name: Reviewdog suggester (Terraform fmt)
+        uses: reviewdog/action-suggester@v1
+        with:
+          tool_name: "terraform fmt -recursive"
       - name: Validate Terraform
         run: terraform validate
       - uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 # v4.0.1
         name: Cache TFLint plugin dir
         with:
           path: ~/.tflint.d/plugins
           key: tflint-${{ hashFiles('.tflint.hcl') }}
-      - name: Setup TFLint
-        uses: terraform-linters/setup-tflint@19a52fbac37dacb22a09518e4ef6ee234f2d4987 # v4.0.0
+      # - name: Setup TFLint
+      #   uses: terraform-linters/setup-tflint@19a52fbac37dacb22a09518e4ef6ee234f2d4987 # v4.0.0
+      #   with:
+      #     github_token: ${{ secrets.GITHUB_TOKEN }}
+      # - name: Run TFLint
+      #   run: |
+      #     tflint --init -c ${GITHUB_WORKSPACE}/.tflint.hcl
+      #     tflint -c ${GITHUB_WORKSPACE}/.tflint.hcl --var-file ${GITHUB_WORKSPACE}/.github/lint/tflint.tfvars  ${{ inputs.tflint-options }}
+      - name: tflint
+        uses: reviewdog/[email protected]
         with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-      - name: Run TFLint
-        run: |
-          tflint --init -c ${GITHUB_WORKSPACE}/.tflint.hcl
-          tflint -c ${GITHUB_WORKSPACE}/.tflint.hcl --var-file ${GITHUB_WORKSPACE}/.github/lint/tflint.tfvars  ${{ inputs.tflint-options }}
+          tflint_init: true
+          github_token: ${{ secrets.github_token }}
+          tflint_config: ${GITHUB_WORKSPACE}/.tflint.hcl

.github/workflows/terraform.yml

@@ -33,7 +33,7 @@ jobs:
       tf_modules: ${{ steps.find.outputs.modules }}
       tf_examples: ${{ steps.find.outputs.examples }}
 
-  verify_all:
+  verify:
     uses: ./.github/workflows/terraform-validate-template.yml
     name: Verify module for Terraform ${{ matrix.terraform }}
     needs: dirs