Skip to content

Commit 47e30d7

Browse files
committed
Updated the review comments
1 parent e8e4fcd commit 47e30d7

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

lambdas/functions/control-plane/src/scale-runners/scale-up.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,6 @@ export function getGitHubEnterpriseApiUrl() {
357357
if (ghesBaseUrl) {
358358
const url = new URL(ghesBaseUrl);
359359
const domain = url.hostname;
360-
logger.info(`Domain name: ${domain}`);
361360
if (domain.endsWith('.ghe.com')) {
362361
// Data residency: Prepend 'api.'
363362
ghesApiUrl = `https://api.${domain}`;
@@ -366,6 +365,7 @@ export function getGitHubEnterpriseApiUrl() {
366365
ghesApiUrl = `${ghesBaseUrl}/api/v3`;
367366
}
368367
}
368+
logger.debug (`Github Enterprise URLs: api_url - ${ghesApiUrl}; base_url - ${ghesBaseUrl}`)
369369
return { ghesApiUrl, ghesBaseUrl };
370370
}
371371

modules/multi-runner/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ variable "key_name" {
531531
}
532532

533533
variable "ghes_url" {
534-
description = "GitHub Enterprise Server URL. Example: https://github.internal.co - DO NOT SET IF USING PUBLIC GITHUB"
534+
description = "GitHub Enterprise Server URL. Example: https://github.internal.co - DO NOT SET IF USING PUBLIC GITHUB. .However if you are using Github Enterprise Cloud with data-residency (ghe.com), set the endpoint here. Example - https://companyname.ghe.com|"
535535
type = string
536536
default = null
537537
}

modules/runners/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ variable "runner_log_files" {
412412
}
413413

414414
variable "ghes_url" {
415-
description = "GitHub Enterprise Server URL. DO NOT SET IF USING PUBLIC GITHUB"
415+
description = "GitHub Enterprise Server URL. DO NOT SET IF USING PUBLIC GITHUB..However if you are using Github Enterprise Cloud with data-residency (ghe.com), set the endpoint here. Example - https://companyname.ghe.com|"
416416
type = string
417417
default = null
418418
}

0 commit comments

Comments
 (0)