Skip to content

Commit 365661e

Browse files
committed
cleanup
1 parent adf77a3 commit 365661e

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

docs/configuration.md

-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ You can configure runners to be ephemeral, in which case runners will be used on
120120
- The scale down lambda is still active, and should only remove orphan instances. But there is no strict check in place. So ensure you configure the `minimum_running_time_in_minutes` to a value that is high enough to get your runner booted and connected to avoid it being terminated before executing a job.
121121
- The messages sent from the webhook lambda to the scale-up lambda are by default delayed by SQS, to give available runners a chance to start the job before the decision is made to scale more runners. For ephemeral runners there is no need to wait. Set `delay_webhook_event` to `0`.
122122
- All events in the queue will lead to a new runner created by the lambda. By setting `enable_job_queued_check` to `true` you can enforce a rule of only creating a runner if the event has a correlated queued job. Setting this can avoid creating useless runners. For example, a job getting cancelled before a runner was created or if the job was already picked up by another runner. We suggest using this in combination with a pool.
123-
- To ensure runners are created in the same order GitHub sends the events, by default we use a FIFO queue. This is mainly relevant for repo level runners. For ephemeral runners you can set `enable_fifo_build_queue` to `false`.
124123
- Errors related to scaling should be retried via SQS. You can configure `job_queue_retention_in_seconds` and `redrive_build_queue` to tune the behavior. We have no mechanism to avoid events never being processed, which means potentially no runner gets created and the job in GitHub times out in 6 hours.
125124

126125
The example for [ephemeral runners](examples/ephemeral.md) is based on the [default example](examples/default.md). Have look at the diff to see the major configuration differences.

lambdas/functions/webhook/src/sqs/index.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { SendMessageCommandInput } from '@aws-sdk/client-sqs';
2-
import { ActionRequestMessage, sendActionRequest } from '.';
2+
import { sendActionRequest } from '.';
33

44
const mockSQS = {
55
sendMessage: jest.fn(() => {

0 commit comments

Comments
 (0)