allow passing optional parameters to the function without getter.

Author: ghostiam

processor.go

@@ -77,17 +77,65 @@ func (c *processor) process(n ast.Node) (*Result, error) {
 			}
 		}
 
-		f, ok := x.Fun.(*ast.SelectorExpr)
-		if !ok {
-			return &Result{}, nil
-		}
+		switch fun := x.Fun.(type) {
+		case *ast.Ident:
+			// Allow passing optional parameters to the function without getter.
 
-		if !isProtoMessage(c.info, f.X) {
+			if len(x.Args) == 0 {
+				return &Result{}, nil
+			}
+
+			if fun.Obj == nil || fun.Obj.Kind != ast.Fun {
+				return &Result{}, nil
+			}
+
+			decl, ok := fun.Obj.Decl.(*ast.FuncDecl)
+			if !ok || decl.Type == nil || decl.Type.Params == nil {
+				return &Result{}, nil
+			}
+
+			paramTypes := make([]ast.Expr, 0, len(x.Args))
+			for _, p := range decl.Type.Params.List {
+				count := max(len(p.Names), 1)
+				for range count {
+					paramTypes = append(paramTypes, p.Type)
+				}
+			}
+
+			for i, arg := range x.Args {
+				a, ok := arg.(*ast.SelectorExpr)
+				if !ok {
+					continue
+				}
+
+				_, isParamPointer := paramTypes[i].(*ast.StarExpr)
+				if !isParamPointer {
+					return &Result{}, nil
+				}
+
+				if !isProtoMessage(c.info, a.X) {
+					continue
+				}
+
+				hasPointer, ok := getterResultHasPointer(c.info, a.X, a.Sel.Name)
+				if !ok || hasPointer {
+					continue
+				}
+
+				c.filter.AddPos(a.Sel.Pos())
+			}
+
+		case *ast.SelectorExpr:
+			if !isProtoMessage(c.info, fun.X) {
+				return &Result{}, nil
+			}
+
+			c.processInner(x)
+
+		default:
 			return &Result{}, nil
 		}
 
-		c.processInner(x)
-
 	case *ast.SelectorExpr:
 		if !isProtoMessage(c.info, x.X) {
 			// If the selector is not on a proto message, skip it.

testdata/test.go

@@ -119,6 +119,10 @@ func testInvalid(t *proto.Test) {
 	_ = structWithPtrField{
 		OptBool: t.Embedded.OptBool, // want `avoid direct access to proto field t\.Embedded\.OptBool, use t\.GetEmbedded\(\)\.OptBool instead`
 	}
+
+	optionalArgsFunc(t.Embedded.OptBool)             // want `avoid direct access to proto field t\.Embedded\.OptBool, use t\.GetEmbedded\(\)\.OptBool instead`
+	optionalArgs2Func(t.OptBool, t.Embedded.OptBool) // want `avoid direct access to proto field t\.Embedded\.OptBool, use t\.GetEmbedded\(\)\.OptBool instead`
+	messageArgsFunc(t.Embedded)                      // want `avoid direct access to proto field t\.Embedded, use t\.GetEmbedded\(\) instead`
 }
 
 func testValid(t *proto.Test) {
@@ -219,9 +223,18 @@ func testValid(t *proto.Test) {
 	_ = structWithPtrField{
 		OptBool: t.GetEmbedded().OptBool,
 	}
+
+	optionalArgsFunc(t.GetEmbedded().OptBool)
+	optionalArgs2Func(t.OptBool, t.GetEmbedded().OptBool)
+	messageArgsFunc(t.GetEmbedded())
 }
 
 // stubs
 func slicesIndexFunc[S ~[]E, E any](s S, f func(E) bool) int {
 	return 0
 }
+
+func optionalArgsFunc(*bool)       {}
+func optionalArgs2Func(a, b *bool) {}
+
+func messageArgsFunc(*proto.Embedded) {}

testdata/test.go.golden

@@ -120,6 +120,10 @@ func testInvalid(t *proto.Test) {
 	_ = structWithPtrField{
 		OptBool: t.GetEmbedded().OptBool, // want `avoid direct access to proto field t\.Embedded\.OptBool, use t\.GetEmbedded\(\)\.OptBool instead`
 	}
+
+	optionalArgsFunc(t.GetEmbedded().OptBool)             // want `avoid direct access to proto field t\.Embedded\.OptBool, use t\.GetEmbedded\(\)\.OptBool instead`
+	optionalArgs2Func(t.OptBool, t.GetEmbedded().OptBool) // want `avoid direct access to proto field t\.Embedded\.OptBool, use t\.GetEmbedded\(\)\.OptBool instead`
+	messageArgsFunc(t.GetEmbedded())                      // want `avoid direct access to proto field t\.Embedded, use t\.GetEmbedded\(\) instead`
 }
 
 func testValid(t *proto.Test) {
@@ -220,9 +224,18 @@ func testValid(t *proto.Test) {
 	_ = structWithPtrField{
 		OptBool: t.GetEmbedded().OptBool,
 	}
+
+	optionalArgsFunc(t.GetEmbedded().OptBool)
+	optionalArgs2Func(t.OptBool, t.GetEmbedded().OptBool)
+	messageArgsFunc(t.GetEmbedded())
 }
 
 // stubs
 func slicesIndexFunc[S ~[]E, E any](s S, f func(E) bool) int {
 	return 0
 }
+
+func optionalArgsFunc(*bool) {}
+func optionalArgs2Func(a, b *bool) {}
+
+func messageArgsFunc(*proto.Embedded) {}