[BUGFIX] #244 Fix removing belongsTo relations (#245)

frans-beech-it · web-flow · commit ead645a0a8b6 · 2020-10-12T13:47:17.000+01:00
diff --git a/projects/angular2-jsonapi/src/services/json-api-datastore.service.ts b/projects/angular2-jsonapi/src/services/json-api-datastore.service.ts
@@ -287,6 +287,16 @@ export class JsonApiDatastore {
               data: relationshipData
             };
           }
+        }  else if (data[key] === null) {
+          const entity = belongsToMetadata.find((entity: any) => entity.propertyName === key);
+
+          if (entity) {
+            relationships = relationships || {};
+
+            relationships[entity.relationship] = {
+              data: null
+            };
+          }
         }
       }
     }
@@ -459,7 +469,7 @@ export class JsonApiDatastore {
     const modelsTypes: any = Reflect.getMetadata('JsonApiDatastoreConfig', this.constructor).models;
 
     for (const relationship in relationships) {
-      if (relationships.hasOwnProperty(relationship) && model.hasOwnProperty(relationship)) {
+      if (relationships.hasOwnProperty(relationship) && model.hasOwnProperty(relationship) && model[relationship]) {
         const relationshipModel: JsonApiModel = model[relationship];
         const hasMany: any[] = Reflect.getMetadata('HasMany', relationshipModel);
         const propertyHasMany: any = find(hasMany, (property) => {

Original file line number	Diff line number	Diff line change
`@@ -287,6 +287,16 @@ export class JsonApiDatastore {`
`287`	`287`	`data: relationshipData`
`288`	`288`	`};`
`289`	`289`	`}`
	`290`	`+ } else if (data[key] === null) {`
	`291`	`+ const entity = belongsToMetadata.find((entity: any) => entity.propertyName === key);`
	`292`	`+`
	`293`	`+ if (entity) {`
	`294`	`+ relationships = relationships \|\| {};`
	`295`	`+`
	`296`	`+ relationships[entity.relationship] = {`
	`297`	`+ data: null`
	`298`	`+ };`
	`299`	`+ }`
`290`	`300`	`}`
`291`	`301`	`}`
`292`	`302`	`}`
`@@ -459,7 +469,7 @@ export class JsonApiDatastore {`
`459`	`469`	`const modelsTypes: any = Reflect.getMetadata('JsonApiDatastoreConfig', this.constructor).models;`
`460`	`470`
`461`	`471`	`for (const relationship in relationships) {`
`462`		`- if (relationships.hasOwnProperty(relationship) && model.hasOwnProperty(relationship)) {`
	`472`	`+ if (relationships.hasOwnProperty(relationship) && model.hasOwnProperty(relationship) && model[relationship]) {`
`463`	`473`	`const relationshipModel: JsonApiModel = model[relationship];`
`464`	`474`	`const hasMany: any[] = Reflect.getMetadata('HasMany', relationshipModel);`
`465`	`475`	`const propertyHasMany: any = find(hasMany, (property) => {`