redshift: add support for CREATE VIEW … WITH NO SCHEMA BINDING

Author: lustefaniak

src/ast/mod.rs

@@ -1282,6 +1282,7 @@ pub enum Statement {
         cluster_by: Vec<Ident>,
         destination_table: Option<ObjectName>,
         columns_with_types: Vec<ColumnDef>,
+        late_binding: bool,
     },
     /// CREATE TABLE
     CreateTable {
@@ -2110,6 +2111,7 @@ impl fmt::Display for Statement {
                 cluster_by,
                 destination_table,
                 columns_with_types,
+                late_binding
             } => {
                 write!(
                     f,
@@ -2135,7 +2137,11 @@ impl fmt::Display for Statement {
                 if !cluster_by.is_empty() {
                     write!(f, " CLUSTER BY ({})", display_comma_separated(cluster_by))?;
                 }
-                write!(f, " AS {query}")
+                write!(f, " AS {query}")?;
+                if *late_binding{
+                    write!(f, " WITH NO SCHEMA BINDING")?;
+                }
+                Ok(())
             }
             Statement::CreateTable {
                 name,

src/keywords.rs

@@ -109,6 +109,7 @@ define_keywords!(
     BIGINT,
     BIGNUMERIC,
     BINARY,
+    BINDING,
     BLOB,
     BOOLEAN,
     BOTH,

src/parser.rs

@@ -2822,6 +2822,9 @@ impl<'a> Parser<'a> {
         self.expect_keyword(Keyword::AS)?;
         let query = Box::new(self.parse_query()?);
         // Optional `WITH [ CASCADED | LOCAL ] CHECK OPTION` is widely supported here.
+
+        let late_binding = dialect_of!(self is RedshiftSqlDialect) && self.parse_keywords(&[Keyword::WITH, Keyword::NO, Keyword::SCHEMA, Keyword::BINDING]);
+
         Ok(Statement::CreateView {
             name,
             columns,
@@ -2832,6 +2835,7 @@ impl<'a> Parser<'a> {
             cluster_by,
             destination_table,
             columns_with_types,
+            late_binding
         })
     }
 

tests/sqlparser_common.rs

@@ -5015,6 +5015,7 @@ fn parse_create_view() {
             cluster_by,
             destination_table,
             columns_with_types,
+            late_binding,
         } => {
             assert_eq!("myschema.myview", name.to_string());
             assert_eq!(Vec::<Ident>::new(), columns);
@@ -5025,6 +5026,7 @@ fn parse_create_view() {
             assert_eq!(cluster_by, vec![]);
             assert_eq!(destination_table, None);
             assert_eq!(columns_with_types, vec![]);
+            assert_eq!(late_binding, false);
         }
         _ => unreachable!(),
     }
@@ -5067,6 +5069,7 @@ fn parse_create_view_with_columns() {
             cluster_by,
             destination_table,
             columns_with_types,
+            late_binding,
         } => {
             assert_eq!("v", name.to_string());
             assert_eq!(columns, vec![Ident::new("has"), Ident::new("cols")]);
@@ -5077,6 +5080,7 @@ fn parse_create_view_with_columns() {
             assert_eq!(cluster_by, vec![]);
             assert_eq!(destination_table, None);
             assert_eq!(columns_with_types, vec![]);
+            assert_eq!(late_binding, false);
         }
         _ => unreachable!(),
     }
@@ -5096,6 +5100,7 @@ fn parse_create_or_replace_view() {
             cluster_by,
             destination_table,
             columns_with_types,
+            late_binding,
         } => {
             assert_eq!("v", name.to_string());
             assert_eq!(columns, vec![]);
@@ -5106,6 +5111,7 @@ fn parse_create_or_replace_view() {
             assert_eq!(cluster_by, vec![]);
             assert_eq!(destination_table, None);
             assert_eq!(columns_with_types, vec![]);
+            assert_eq!(late_binding, false);
         }
         _ => unreachable!(),
     }
@@ -5129,6 +5135,7 @@ fn parse_create_or_replace_materialized_view() {
             cluster_by,
             destination_table,
             columns_with_types,
+            late_binding,
         } => {
             assert_eq!("v", name.to_string());
             assert_eq!(columns, vec![]);
@@ -5139,6 +5146,7 @@ fn parse_create_or_replace_materialized_view() {
             assert_eq!(cluster_by, vec![]);
             assert_eq!(destination_table, None);
             assert_eq!(columns_with_types, vec![]);
+            assert_eq!(late_binding, false);
         }
         _ => unreachable!(),
     }
@@ -5158,6 +5166,7 @@ fn parse_create_materialized_view() {
             cluster_by,
             destination_table,
             columns_with_types,
+            late_binding,
         } => {
             assert_eq!("myschema.myview", name.to_string());
             assert_eq!(Vec::<Ident>::new(), columns);
@@ -5168,6 +5177,7 @@ fn parse_create_materialized_view() {
             assert_eq!(cluster_by, vec![]);
             assert_eq!(destination_table, None);
             assert_eq!(columns_with_types, vec![]);
+            assert_eq!(late_binding, false);
         }
         _ => unreachable!(),
     }
@@ -5186,7 +5196,8 @@ fn parse_create_materialized_view_with_cluster_by() {
             with_options,
             cluster_by,
             destination_table,
-            columns_with_types
+            columns_with_types,
+            late_binding,
         } => {
             assert_eq!("myschema.myview", name.to_string());
             assert_eq!(Vec::<Ident>::new(), columns);
@@ -5197,6 +5208,7 @@ fn parse_create_materialized_view_with_cluster_by() {
             assert_eq!(cluster_by, vec![Ident::new("foo")]);
             assert_eq!(destination_table, None);
             assert_eq!(columns_with_types, vec![]);
+            assert_eq!(late_binding, false);
         }
         _ => unreachable!(),
     }

tests/sqlparser_redshift.rs

@@ -280,3 +280,8 @@ fn test_sharp() {
 fn test_select_ignore_nulls() {
     redshift().verified_stmt("SELECT last_value(b) IGNORE NULLS FROM test_data");
 }
+
+#[test]
+fn test_create_view_late_binding() {
+    redshift().verified_stmt("CREATE VIEW myevent AS SELECT eventname FROM event WITH NO SCHEMA BINDING");
+}