fix for maybe_parse preventing parser from erroring on recursion limit (apache#1464)

Author: tomershaniii

src/ast/mod.rs

@@ -3208,7 +3208,7 @@ pub enum Statement {
         /// Table confs
         options: Vec<SqlOption>,
         /// Cache table as a Query
-        query: Option<Query>,
+        query: Option<Box<Query>>,
     },
     /// ```sql
     /// UNCACHE TABLE [ IF EXISTS ]  <table_name>
@@ -6883,7 +6883,7 @@ impl fmt::Display for MacroArg {
 #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
 pub enum MacroDefinition {
     Expr(Expr),
-    Table(Query),
+    Table(Box<Query>),
 }
 
 impl fmt::Display for MacroDefinition {

src/ast/query.rs

@@ -1103,7 +1103,7 @@ pub enum PivotValueSource {
     /// Pivot on all values returned by a subquery.
     ///
     /// See <https://docs.snowflake.com/en/sql-reference/constructs/pivot#pivot-on-column-values-using-a-subquery-with-dynamic-pivot>.
-    Subquery(Query),
+    Subquery(Box<Query>),
 }
 
 impl fmt::Display for PivotValueSource {

src/dialect/mod.rs

@@ -486,9 +486,9 @@ pub trait Dialect: Debug + Any {
     fn parse_column_option(
         &self,
         _parser: &mut Parser,
-    ) -> Option<Result<Option<ColumnOption>, ParserError>> {
+    ) -> Result<Option<Result<Option<ColumnOption>, ParserError>>, ParserError> {
         // return None to fall back to the default behavior
-        None
+        Ok(None)
     }
 
     /// Decide the lexical Precedence of operators.

src/dialect/snowflake.rs

@@ -156,7 +156,7 @@ impl Dialect for SnowflakeDialect {
     fn parse_column_option(
         &self,
         parser: &mut Parser,
-    ) -> Option<Result<Option<ColumnOption>, ParserError>> {
+    ) -> Result<Option<Result<Option<ColumnOption>, ParserError>>, ParserError> {
         parser.maybe_parse(|parser| {
             let with = parser.parse_keyword(Keyword::WITH);
 
@@ -247,7 +247,7 @@ pub fn parse_create_table(
                     builder = builder.comment(parser.parse_optional_inline_comment()?);
                 }
                 Keyword::AS => {
-                    let query = parser.parse_boxed_query()?;
+                    let query = parser.parse_query()?;
                     builder = builder.query(Some(query));
                     break;
                 }

src/parser/alter.rs

@@ -192,7 +192,7 @@ impl<'a> Parser<'a> {
             let _ = self.parse_keyword(Keyword::WITH);
             // option
             let mut options = vec![];
-            while let Some(opt) = self.maybe_parse(|parser| parser.parse_pg_role_option()) {
+            while let Some(opt) = self.maybe_parse(|parser| parser.parse_pg_role_option())? {
                 options.push(opt);
             }
             // check option