Retain traces on failure, fix test-results folder

Author: andreiborza

.github/workflows/build.yml

@@ -1008,7 +1008,7 @@ jobs:
         if: failure()
         with:
           name: playwright-traces-job_e2e_playwright_tests-${{ matrix.test-application}}
-          path: dev-packages/e2e-tests/test-results
+          path: dev-packages/e2e-tests/test-applications/${{ matrix.test-application}}/test-results
           overwrite: true
           retention-days: 7
 

dev-packages/e2e-tests/.gitignore

@@ -4,4 +4,3 @@ tmp
 .tmp_build_stderr
 pnpm-lock.yaml
 .last-run.json
-test-results

dev-packages/test-utils/src/playwright-config.ts

@@ -46,7 +46,7 @@ export function getPlaywrightConfig(
       baseURL: `http://localhost:${appPort}`,
 
       /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
-      trace: 'on-first-retry',
+      trace: 'retain-on-failure',
     },
 
     /* Configure projects for major browsers */