Skip to content

Commit 708276e

Browse files
committed
Remove timeouts
1 parent 0158ff8 commit 708276e

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1002,7 +1002,7 @@ jobs:
10021002
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
10031003
timeout-minutes: 5
10041004
run: pnpm test:assert
1005-
1005+
10061006
- name: Upload Playwright Traces
10071007
uses: actions/upload-artifact@v4
10081008
if: failure()

dev-packages/e2e-tests/test-applications/solidstart/tests/errorboundary.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ test('captures an exception', async ({ page }) => {
1010
);
1111
});
1212

13-
await page.waitForTimeout(5000);
1413
await page.goto('/error-boundary');
1514
await page.locator('#caughtErrorBtn').click();
1615
const errorEvent = await errorEventPromise;
@@ -41,7 +40,6 @@ test('captures a second exception after resetting the boundary', async ({ page }
4140
);
4241
});
4342

44-
await page.waitForTimeout(5000);
4543
await page.goto('/error-boundary');
4644
await page.locator('#caughtErrorBtn').click();
4745
const firstErrorEvent = await firstErrorEventPromise;

0 commit comments

Comments
 (0)