Skip to content

Commit 24dee7f

Browse files
committed
Work pls
1 parent 73dd2f1 commit 24dee7f

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

dev-packages/e2e-tests/test-applications/solidstart/src/routes/client-error.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export default function ClientErrorPage() {
2828
class="border rounded-lg px-2 mb-2 border-red-500 text-red-500 cursor-pointer"
2929
id="errorBtn"
3030
onClick={() => {
31-
throw new Error('Error thrown from Solid Start E2E test app');
31+
throw new Error('Uncaught error thrown from Solid Start E2E test app');
3232
}}
3333
>
3434
Throw uncaught error

dev-packages/e2e-tests/test-applications/solidstart/tests/errorboundary.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForError } from '@sentry-internal/test-utils';
33

4-
test.skip('captures an exception', async ({ page }) => {
4+
test('captures an exception', async ({ page }) => {
55
const errorEventPromise = waitForError('solidstart', errorEvent => {
66
return (
77
!errorEvent.type &&

dev-packages/e2e-tests/test-applications/solidstart/tests/errors.client.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { waitForError } from '@sentry-internal/test-utils';
44
test.describe('client-side errors', () => {
55
test('captures error thrown on click', async ({ page }) => {
66
const errorPromise = waitForError('solidstart', async errorEvent => {
7-
return errorEvent?.exception?.values?.[0]?.value === 'Error thrown from Solid Start E2E test app';
7+
return errorEvent?.exception?.values?.[0]?.value === 'Uncaught error thrown from Solid Start E2E test app';
88
});
99

1010
await page.goto(`/client-error`);
@@ -16,7 +16,7 @@ test.describe('client-side errors', () => {
1616
values: [
1717
{
1818
type: 'Error',
19-
value: 'Error thrown from Solid Start E2E test app',
19+
value: 'Uncaught error thrown from Solid Start E2E test app',
2020
mechanism: {
2121
type: 'instrument',
2222
handled: false,

0 commit comments

Comments
 (0)