Skip to content

Commit 4b26b23

Browse files
committed
ref: Use filepath.Base to get filename
1 parent cf1a602 commit 4b26b23

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

stacktrace.go

+1-6
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ func NewFrame(f runtime.Frame) Frame {
159159
var module string
160160

161161
if filename != "" {
162-
filename = extractFilename(filename)
162+
filename = filepath.Base(filename)
163163
} else {
164164
filename = unknown
165165
}
@@ -226,11 +226,6 @@ func filterFrames(frames []Frame) []Frame {
226226
return filteredFrames
227227
}
228228

229-
func extractFilename(path string) string {
230-
_, file := filepath.Split(path)
231-
return file
232-
}
233-
234229
func isInAppFrame(frame Frame) bool {
235230
if strings.HasPrefix(frame.AbsPath, build.Default.GOROOT) ||
236231
strings.Contains(frame.Module, "vendor") ||

stacktrace_test.go

+2
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ func TestNewStacktrace(t *testing.T) {
3131

3232
assertEqual(t, len(stacktrace.Frames), 2)
3333
assertEqual(t, stacktrace.Frames[0].Function, "TestNewStacktrace")
34+
assertEqual(t, stacktrace.Frames[0].Filename, "stacktrace_test.go")
3435
assertEqual(t, stacktrace.Frames[1].Function, "Trace")
36+
assertEqual(t, stacktrace.Frames[1].Filename, "errors_test.go")
3537
}
3638

3739
func BenchmarkNewStacktrace(b *testing.B) {

0 commit comments

Comments
 (0)