fix(app-start): Move app_start_type to exclusive_time (#3049)

This tag was added to the wrong metric, exclusive_time_light. Move it to
the correct metric for querying.

#skip-changelog

Author: narsaynorath

relay-dynamic-config/src/defaults.rs

@@ -181,6 +181,9 @@ fn span_metrics() -> impl IntoIterator<Item = MetricSpec> {
                 Tag::with_key("span.main_thread")
                     .from_field("span.sentry_tags.main_thread")
                     .when(is_mobile.clone()),
+                Tag::with_key("app_start_type")
+                    .from_field("span.sentry_tags.app_start_type")
+                    .when(is_mobile.clone()),
                 // Resource module:
                 Tag::with_key("file_extension")
                     .from_field("span.sentry_tags.file_extension")
@@ -230,9 +233,6 @@ fn span_metrics() -> impl IntoIterator<Item = MetricSpec> {
                 Tag::with_key("release")
                     .from_field("span.sentry_tags.release")
                     .when(is_mobile.clone()),
-                Tag::with_key("app_start_type")
-                    .from_field("span.sentry_tags.app_start_type")
-                    .when(is_mobile.clone()),
                 // Resource module:
                 Tag::with_key("file_extension")
                     .from_field("span.sentry_tags.file_extension")

relay-server/src/metrics_extraction/snapshots/relay_server__metrics_extraction__event__tests__extract_span_metrics_mobile.snap

@@ -310,6 +310,7 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
+                "app_start_type": "warm",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -330,7 +331,6 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
-                "app_start_type": "warm",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -372,6 +372,7 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
+                "app_start_type": "warm",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -391,7 +392,6 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
-                "app_start_type": "warm",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -431,6 +431,7 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
+                "app_start_type": "warm",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -453,7 +454,6 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
-                "app_start_type": "warm",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -539,6 +539,7 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
+                "app_start_type": "warm",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -560,7 +561,6 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
-                "app_start_type": "warm",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -602,6 +602,7 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
+                "app_start_type": "warm",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -623,7 +624,6 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
-                "app_start_type": "warm",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -665,6 +665,7 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
+                "app_start_type": "cold",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",
@@ -686,7 +687,6 @@ expression: "(&event.value().unwrap().spans, metrics)"
                 ],
             ),
             tags: {
-                "app_start_type": "cold",
                 "device.class": "1",
                 "os.name": "iOS",
                 "release": "1.2.3",