fix(gatsby-dev-cli): Correctly catch 404s from NPM when a package hasn't been published yet (#28297)

* fix(gatsby-dev-cli): Correctly catch 404s from NPM when a package hasn't been published yet

* Use async/await

Co-authored-by: Peter van der Zee <[email protected]>

Co-authored-by: Peter van der Zee <[email protected]>

Author: KyleAMathews

packages/gatsby-dev-cli/src/utils/check-deps-changes.js

@@ -60,17 +60,13 @@ exports.checkDepsChanges = async ({
     // this allow us to not publish to local repository
     // and save some time/work
     try {
-      localPKGjson = await new Promise((resolve, reject) => {
-        got(`https://unpkg.com/${packageName}/package.json`).then(
-          (error, response) => {
-            if (response && response.statusCode === 200) {
-              return resolve(JSON.parse(response.body))
-            }
-
-            return reject(error)
-          }
-        )
-      })
+      const response = await got(
+        `https://unpkg.com/${packageName}/package.json`
+      )
+      if (response?.statusCode !== 200) {
+        throw new Error(`No response or non 200 code`)
+      }
+      localPKGjson = JSON.parse(response.body)
     } catch {
       console.log(
         `'${packageName}' doesn't seem to be installed and is not published on NPM.`