fix(gatsby): try to get linenumber from compile error (#30615)

wardpeet · web-flow · commit 7dd645d65dd9 · 2021-04-22T17:36:47.000+02:00
diff --git a/packages/gatsby/cache-dir/fast-refresh-overlay/components/build-error.js b/packages/gatsby/cache-dir/fast-refresh-overlay/components/build-error.js
@@ -14,6 +14,12 @@ export function BuildError({ error }) {
   const decoded = prettifyStack(error)
   const [filePath] = decoded
   const file = filePath.content.split(`\n`)[0]
+  const lineMatch = filePath.content.match(/\((\d+)[^)]+\)/)
+  let line = 1
+
+  if (lineMatch) {
+    line = lineMatch[1]
+  }
 
   return (
     <Overlay>
@@ -22,7 +28,10 @@ export function BuildError({ error }) {
           <h1 id="gatsby-overlay-labelledby">Failed to compile</h1>
           <span>{file}</span>
         </div>
-        <HeaderOpenClose open={() => openInEditor(file, 1)} dismiss={false} />
+        <HeaderOpenClose
+          open={() => openInEditor(file, line)}
+          dismiss={false}
+        />
       </Header>
       <Body>
         <h2>Source</h2>
diff --git a/packages/gatsby/cache-dir/fast-refresh-overlay/utils.js b/packages/gatsby/cache-dir/fast-refresh-overlay/utils.js
@@ -23,7 +23,7 @@ export function prettifyStack(errorInformation) {
 }
 
 export function openInEditor(file, lineNumber = 1) {
-  window.fetch(
+  fetch(
     `/__open-stack-frame-in-editor?fileName=` +
       window.encodeURIComponent(file) +
       `&lineNumber=` +

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export function prettifyStack(errorInformation) {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`export function openInEditor(file, lineNumber = 1) {`
`26`		`- window.fetch(`
	`26`	`+ fetch(`
`27`	`27`	`/__open-stack-frame-in-editor?fileName=` +
`28`	`28`	`window.encodeURIComponent(file) +`
`29`	`29`	`&lineNumber=` +