feat(gatsby): Turn on Functions experiment for everybody (#31807) (#31826)

* Ship functions for everyone

* Set FUNCTIONS to LOCKED_IN

* Add mock for panicOnBuild

* Fix test

* Update packages/gatsby/src/bootstrap/load-plugins/load.ts

Co-authored-by: Vladimir Razuvaev <[email protected]>

Co-authored-by: Vladimir Razuvaev <[email protected]>
(cherry picked from commit a485415)

Co-authored-by: Sidhartha Chatterjee <[email protected]>

Author: GatsbyJS Bot

packages/gatsby/src/bootstrap/load-plugins/__tests__/__snapshots__/load-plugins.ts.snap

@@ -86,6 +86,21 @@ Array [
     "ssrAPIs": Array [],
     "version": "1.0.0",
   },
+  Object {
+    "browserAPIs": Array [],
+    "id": "",
+    "name": "functions",
+    "nodeAPIs": Array [
+      "onPreBootstrap",
+      "onCreateDevServer",
+    ],
+    "pluginOptions": Object {
+      "plugins": Array [],
+    },
+    "resolve": "",
+    "ssrAPIs": Array [],
+    "version": "1.0.0",
+  },
   Object {
     "browserAPIs": Array [],
     "id": "",
@@ -194,6 +209,24 @@ Array [
     "ssrAPIs": Array [],
     "version": "1.0.0",
   },
+  Object {
+    "browserAPIs": Array [],
+    "id": "",
+    "name": "gatsby-plugin-page-creator",
+    "nodeAPIs": Array [
+      "createPagesStatefully",
+      "setFieldsOnGraphQLNodeType",
+      "onPreInit",
+    ],
+    "pluginOptions": Object {
+      "path": "<PROJECT_ROOT>/packages/gatsby/src/internal-plugins/functions/src/pages",
+      "pathCheck": false,
+      "plugins": Array [],
+    },
+    "resolve": "",
+    "ssrAPIs": Array [],
+    "version": "1.0.0",
+  },
   Object {
     "browserAPIs": Array [],
     "id": "",
@@ -333,6 +366,21 @@ Array [
     "ssrAPIs": Array [],
     "version": "1.0.0",
   },
+  Object {
+    "browserAPIs": Array [],
+    "id": "",
+    "name": "functions",
+    "nodeAPIs": Array [
+      "onPreBootstrap",
+      "onCreateDevServer",
+    ],
+    "pluginOptions": Object {
+      "plugins": Array [],
+    },
+    "resolve": "",
+    "ssrAPIs": Array [],
+    "version": "1.0.0",
+  },
   Object {
     "browserAPIs": Array [],
     "id": "",
@@ -453,6 +501,24 @@ Array [
     "ssrAPIs": Array [],
     "version": "1.0.0",
   },
+  Object {
+    "browserAPIs": Array [],
+    "id": "",
+    "name": "gatsby-plugin-page-creator",
+    "nodeAPIs": Array [
+      "createPagesStatefully",
+      "setFieldsOnGraphQLNodeType",
+      "onPreInit",
+    ],
+    "pluginOptions": Object {
+      "path": "<PROJECT_ROOT>/packages/gatsby/src/internal-plugins/functions/src/pages",
+      "pathCheck": false,
+      "plugins": Array [],
+    },
+    "resolve": "",
+    "ssrAPIs": Array [],
+    "version": "1.0.0",
+  },
   Object {
     "browserAPIs": Array [],
     "id": "",
@@ -610,6 +676,21 @@ Array [
     "ssrAPIs": Array [],
     "version": "1.0.0",
   },
+  Object {
+    "browserAPIs": Array [],
+    "id": "",
+    "name": "functions",
+    "nodeAPIs": Array [
+      "onPreBootstrap",
+      "onCreateDevServer",
+    ],
+    "pluginOptions": Object {
+      "plugins": Array [],
+    },
+    "resolve": "",
+    "ssrAPIs": Array [],
+    "version": "1.0.0",
+  },
   Object {
     "browserAPIs": Array [],
     "id": "",
@@ -738,6 +819,24 @@ Array [
     "ssrAPIs": Array [],
     "version": "1.0.0",
   },
+  Object {
+    "browserAPIs": Array [],
+    "id": "",
+    "name": "gatsby-plugin-page-creator",
+    "nodeAPIs": Array [
+      "createPagesStatefully",
+      "setFieldsOnGraphQLNodeType",
+      "onPreInit",
+    ],
+    "pluginOptions": Object {
+      "path": "<PROJECT_ROOT>/packages/gatsby/src/internal-plugins/functions/src/pages",
+      "pathCheck": false,
+      "plugins": Array [],
+    },
+    "resolve": "",
+    "ssrAPIs": Array [],
+    "version": "1.0.0",
+  },
   Object {
     "browserAPIs": Array [],
     "id": "",

packages/gatsby/src/bootstrap/load-plugins/__tests__/load-plugins.ts

@@ -8,6 +8,7 @@ jest.mock(`gatsby-cli/lib/reporter`, () => {
   return {
     error: jest.fn(),
     panic: jest.fn(),
+    panicOnBuild: jest.fn(),
     log: jest.fn(),
     warn: jest.fn(),
     success: jest.fn(),

packages/gatsby/src/bootstrap/load-plugins/load.ts

@@ -243,8 +243,7 @@ export function loadPlugins(
     `../../internal-plugins/prod-404`,
     `../../internal-plugins/webpack-theme-component-shadowing`,
     `../../internal-plugins/bundle-optimisations`,
-    process.env.GATSBY_EXPERIMENTAL_FUNCTIONS &&
-      `../../internal-plugins/functions`,
+    `../../internal-plugins/functions`,
   ].filter(Boolean) as Array<string>
   internalPlugins.forEach(relPath => {
     const absPath = path.join(__dirname, relPath)

packages/gatsby/src/internal-plugins/functions/package.json

@@ -2,7 +2,7 @@
   "name": "functions",
   "version": "1.0.0",
   "description": "An internal Gatsby plugin which lets one write serverless functions",
-  "main": "index.js",
+  "main": "index.ts",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"
   },

packages/gatsby/src/internal-plugins/internal-data-bridge/gatsby-node.js

@@ -119,46 +119,8 @@ exports.sourceNodes = ({
   watchConfig(pathToGatsbyConfig, createGatsbyConfigNode)
 
   // Create nodes for functions
-  if (process.env.GATSBY_EXPERIMENTAL_FUNCTIONS) {
-    const { functions } = store.getState()
-    const createFunctionNode = config => {
-      createNode({
-        id: `gatsby-function-${config.absoluteCompiledFilePath}`,
-        ...config,
-        parent: null,
-        children: [],
-        internal: {
-          contentDigest: createContentDigest(config),
-          type: `SiteFunction`,
-        },
-      })
-    }
-    functions.forEach(config => {
-      createFunctionNode(config)
-    })
-
-    // Listen for updates to functions to update the nodes.
-    emitter.on(`SET_SITE_FUNCTIONS`, action => {
-      // Identify any now deleted functions and remove their nodes.
-      const existingNodes = getNodesByType(`SiteFunction`)
-      const newFunctionsSet = new Set()
-      action.payload.forEach(config =>
-        newFunctionsSet.add(
-          `gatsby-function-${config.absoluteCompiledFilePath}`
-        )
-      )
-      const toBeDeleted = existingNodes.filter(
-        node => !newFunctionsSet.has(node.id)
-      )
-      toBeDeleted.forEach(node => deleteNode(node))
-
-      action.payload.forEach(config => {
-        createFunctionNode(config)
-      })
-    })
-  } else {
-    // If not enabled, create a dummy node so we can ignore it in the dev 404 page
-    const config = { functionRoute: `FAKE`, absoluteCompiledFilePath: `FAKE` }
+  const { functions } = store.getState()
+  const createFunctionNode = config => {
     createNode({
       id: `gatsby-function-${config.absoluteCompiledFilePath}`,
       ...config,
@@ -170,6 +132,27 @@ exports.sourceNodes = ({
       },
     })
   }
+  functions.forEach(config => {
+    createFunctionNode(config)
+  })
+
+  // Listen for updates to functions to update the nodes.
+  emitter.on(`SET_SITE_FUNCTIONS`, action => {
+    // Identify any now deleted functions and remove their nodes.
+    const existingNodes = getNodesByType(`SiteFunction`)
+    const newFunctionsSet = new Set()
+    action.payload.forEach(config =>
+      newFunctionsSet.add(`gatsby-function-${config.absoluteCompiledFilePath}`)
+    )
+    const toBeDeleted = existingNodes.filter(
+      node => !newFunctionsSet.has(node.id)
+    )
+    toBeDeleted.forEach(node => deleteNode(node))
+
+    action.payload.forEach(config => {
+      createFunctionNode(config)
+    })
+  })
 }
 
 function watchConfig(pathToGatsbyConfig, createGatsbyConfigNode) {

packages/gatsby/src/utils/flags.ts

@@ -180,7 +180,7 @@ const activeFlags: Array<IFlag> = [
     experimental: false,
     description: `Compile Serverless functions in your Gatsby project and write them to disk, ready to deploy to Gatsby Cloud`,
     umbrellaIssue: `https://gatsby.dev/functions-feedback`,
-    testFitness: (): fitnessEnum => true,
+    testFitness: (): fitnessEnum => `LOCKED_IN`,
   },
   {
     name: `CONCURRENT_FEATURES`,