test(gatsby): Add buffer time to failing react 18 e2e tests (#35673)

* Skip failing react 18 tests

* Instead of skipping, add buffer time after route change

* Add to third test

Author: imjoshin

e2e-tests/production-runtime/cypress/integration/lifecycle-methods.js

@@ -4,6 +4,9 @@ describe(`Production build tests`, () => {
 
     cy.getTestElement(`page2`).click().waitForRouteChange()
 
+    // add buffer time so that componentDidMount has time to be called after route change
+    cy.wait(1000)
+
     // we expect 2 `componentDidMount` calls - 1 for initial page and 1 for second page
     cy.lifecycleCallCount(`componentDidMount`).should(`equal`, 2)
     cy.lifecycleCallCount(`render`).should(`equal`, 2)
@@ -14,6 +17,9 @@ describe(`Production build tests`, () => {
 
     cy.getTestElement(`duplicated`).click().waitForRouteChange()
 
+    // add buffer time so that componentDidMount has time to be called after route change
+    cy.wait(1000)
+
     // we expect 2 `componentDidMount` calls - 1 for initial page and 1 for duplicated page
     cy.lifecycleCallCount(`componentDidMount`).should(`equal`, 2)
     cy.lifecycleCallCount(`render`).should(`equal`, 2)
@@ -26,6 +32,9 @@ describe(`Production build tests`, () => {
 
     cy.getTestElement(`/nested/foo`).click().waitForRouteChange()
 
+    // add buffer time so that componentDidMount has time to be called after route change
+    cy.wait(1000)
+
     // we expect just 1 `componentDidMount` call, when navigating inside matchPath
     cy.lifecycleCallCount(`componentDidMount`).should(`equal`, 1)
     cy.lifecycleCallCount(`render`).should(`equal`, 3)