Skip to content

Commit 58eee35

Browse files
authored
fix(gatsby): fix partial hydration constraints (#36468)
* fix(gatsby): fix partial hydration constraints * Update flags.ts * Update flags.ts * lint
1 parent 434ca56 commit 58eee35

File tree

1 file changed

+14
-25
lines changed

1 file changed

+14
-25
lines changed

packages/gatsby/src/utils/flags.ts

+14-25
Original file line numberDiff line numberDiff line change
@@ -184,14 +184,7 @@ const activeFlags: Array<IFlag> = [
184184
experimental: true,
185185
umbrellaIssue: `https://gatsby.dev/lmdb-feedback`,
186186
description: `Store nodes in a persistent embedded database (vs in-memory). Lowers peak memory usage. Requires Node v14.10 or above.`,
187-
testFitness: (): fitnessEnum => {
188-
if (_CFLAGS_.GATSBY_MAJOR === `4`) {
189-
return `LOCKED_IN`
190-
}
191-
192-
const [major, minor] = process.versions.node.split(`.`)
193-
return (Number(major) === 14 && Number(minor) >= 10) || Number(major) > 14
194-
},
187+
testFitness: (): fitnessEnum => `LOCKED_IN`,
195188
requires: `Requires Node v14.10 or above.`,
196189
},
197190
{
@@ -203,14 +196,7 @@ const activeFlags: Array<IFlag> = [
203196
umbrellaIssue: `https://gatsby.dev/pqr-feedback`,
204197
description: `Parallelize running page queries in order to better saturate all available cores. Improves time it takes to run queries during gatsby build. Requires Node v14.10 or above.`,
205198
includedFlags: [`LMDB_STORE`],
206-
testFitness: (): fitnessEnum => {
207-
if (_CFLAGS_.GATSBY_MAJOR === `4`) {
208-
return `LOCKED_IN`
209-
}
210-
211-
const [major, minor] = process.versions.node.split(`.`)
212-
return (Number(major) === 14 && Number(minor) >= 10) || Number(major) > 14
213-
},
199+
testFitness: (): fitnessEnum => `LOCKED_IN`,
214200
requires: `Requires Node v14.10 or above.`,
215201
},
216202
{
@@ -234,10 +220,7 @@ const activeFlags: Array<IFlag> = [
234220
testFitness: (): fitnessEnum => false,
235221
requires: `As of [email protected] this feature is available as a config option inside gatsby-config. Learn more at https://gatsby.dev/graphql-typegen`,
236222
},
237-
]
238-
239-
if (_CFLAGS_.GATSBY_MAJOR === `5`) {
240-
activeFlags.push({
223+
{
241224
name: `PARTIAL_HYDRATION`,
242225
env: `GATSBY_PARTIAL_HYDRATION`,
243226
command: `build`,
@@ -250,13 +233,19 @@ if (_CFLAGS_.GATSBY_MAJOR === `5`) {
250233
react: `>=18.0.0`,
251234
}
252235
const v0Constraint = {
253-
react: `0.0.0`,
236+
react: `^0.0.0`,
254237
}
255238

256-
return satisfiesSemvers(v18Constraint) || satisfiesSemvers(v0Constraint)
239+
return (
240+
_CFLAGS_.GATSBY_MAJOR === `5` &&
241+
(satisfiesSemvers(v18Constraint) || satisfiesSemvers(v0Constraint))
242+
)
257243
},
258-
requires: `Requires React v18 or above.`,
259-
})
260-
}
244+
requires:
245+
Number(_CFLAGS_.GATSBY_MAJOR) < 5
246+
? `Partial hydration is only available in Gatsby V5. Please upgrade Gatsby.`
247+
: `Partial hydration requires React 18+ to work.`,
248+
},
249+
]
261250

262251
export default activeFlags

0 commit comments

Comments
 (0)