Skip to content

Commit 48dbfd7

Browse files
elmarburkefreiksenet
authored andcommitted
fix(gatsby-source-mongodb): fix mapping function signature (#14402)
* fix(gatsby-source-mongodb): fix mapping function signature * test(gatsby-source-mongodb): remove unused parameter
1 parent 1d9ba86 commit 48dbfd7

File tree

4 files changed

+12
-23
lines changed

4 files changed

+12
-23
lines changed

packages/gatsby-source-mongodb/package.json

+4-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@
22
"name": "gatsby-source-mongodb",
33
"description": "Source plugin for pulling data into Gatsby from MongoDB collections",
44
"version": "2.0.19",
5-
"author": "[email protected]",
5+
"authors": [
6+
7+
8+
],
69
"bugs": {
710
"url": "https://github.com/gatsbyjs/gatsby/issues"
811
},

packages/gatsby-source-mongodb/src/__tests__/mapping.js

+6-13
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ const params = {
2020
text: `someText`,
2121
mediaType: `someMediaType`,
2222
createContentDigest: jest.fn().mockReturnValue(`contentDigest`),
23-
createNode: jest.fn(),
2423
}
2524

2625
test(`it returns an object`, () => {
@@ -30,8 +29,7 @@ test(`it returns an object`, () => {
3029
params.key,
3130
params.text,
3231
params.mediaType,
33-
params.createContentDigest,
34-
params.createNode
32+
params.createContentDigest
3533
)
3634
).toHaveProperty(`id`)
3735
expect(
@@ -40,8 +38,7 @@ test(`it returns an object`, () => {
4038
params.key,
4139
params.text,
4240
params.mediaType,
43-
params.createContentDigest,
44-
params.createNode
41+
params.createContentDigest
4542
)
4643
).toHaveProperty(`parent`)
4744
expect(
@@ -50,8 +47,7 @@ test(`it returns an object`, () => {
5047
params.key,
5148
params.text,
5249
params.mediaType,
53-
params.createContentDigest,
54-
params.createNode
50+
params.createContentDigest
5551
)
5652
).toHaveProperty(`children`)
5753
expect(
@@ -60,8 +56,7 @@ test(`it returns an object`, () => {
6056
params.key,
6157
params.text,
6258
params.mediaType,
63-
params.createContentDigest,
64-
params.createNode
59+
params.createContentDigest
6560
)
6661
).toHaveProperty(`internal`)
6762
expect(
@@ -70,8 +65,7 @@ test(`it returns an object`, () => {
7065
params.key,
7166
params.text,
7267
params.mediaType,
73-
params.createContentDigest,
74-
params.createNode
68+
params.createContentDigest
7569
)
7670
).toHaveProperty(`someKey`)
7771
})
@@ -95,8 +89,7 @@ test(`it returns a transformed object`, () => {
9589
params.key,
9690
params.text,
9791
params.mediaType,
98-
params.createContentDigest,
99-
params.createNode
92+
params.createContentDigest
10093
)
10194
).toMatchObject(desiredResult)
10295
})

packages/gatsby-source-mongodb/src/gatsby-node.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ function createNodes(
129129
mediaItemFieldKey,
130130
node[mediaItemFieldKey],
131131
mapObj[mediaItemFieldKey],
132-
createNode
132+
createContentDigest
133133
)
134134

135135
node[`${mediaItemFieldKey}___NODE`] = mappingChildNode.id

packages/gatsby-source-mongodb/src/mapping.js

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,7 @@
11
const camelCase = require(`lodash.camelcase`)
22
const isString = require(`lodash.isstring`)
33

4-
module.exports = function(
5-
node,
6-
key,
7-
text,
8-
mediaType,
9-
createContentDigest,
10-
createNode
11-
) {
4+
module.exports = function(node, key, text, mediaType, createContentDigest) {
125
const str = isString(text) ? text : ` `
136
const id = `${node.id}${key}MappingNode`
147
const mappingNode = {

0 commit comments

Comments
 (0)