fix(gatsby): Proper cache status event (#32962)

* Cache Status definitive cli method

* add test

Author: abhiaiyer91

packages/gatsby/src/redux/__tests__/index.js

@@ -1,8 +1,8 @@
 const _ = require(`lodash`)
 const path = require(`path`)
 const v8 = require(`v8`)
+const telemetry = require(`gatsby-telemetry`)
 const reporter = require(`gatsby-cli/lib/reporter`)
-
 const writeToCache = jest.spyOn(require(`../persist`), `writeToCache`)
 const v8Serialize = jest.spyOn(v8, `serialize`)
 const v8Deserialize = jest.spyOn(v8, `deserialize`)
@@ -150,6 +150,26 @@ describe(`redux db`, () => {
     reporterInfo.mockClear()
   })
 
+  it(`should have cache status telemetry event`, async () => {
+    jest.spyOn(telemetry, `trackCli`)
+
+    readState()
+
+    expect(telemetry.trackCli).toHaveBeenCalledWith(`CACHE_STATUS`, {
+      cacheStatus: `COLD`,
+    })
+
+    store.getState().nodes = getFakeNodes()
+
+    await saveState()
+
+    readState()
+
+    expect(telemetry.trackCli).toHaveBeenCalledWith(`CACHE_STATUS`, {
+      cacheStatus: `WARM`,
+    })
+  })
+
   it(`should write redux cache to disk`, async () => {
     createPages(defaultPage)
 

packages/gatsby/src/redux/index.ts

@@ -41,25 +41,19 @@ export const readState = (): IGatsbyState => {
     // changes. Explicitly delete it here to cover case where user
     // runs gatsby the first time after upgrading.
     delete state[`jsonDataPaths`]
-    telemetry.decorateEvent(`BUILD_END`, {
-      cacheStatus: `WARM`,
-    })
-    telemetry.decorateEvent(`DEVELOP_STOP`, {
+
+    telemetry.trackCli(`CACHE_STATUS`, {
       cacheStatus: `WARM`,
     })
+
     return state
   } catch (e) {
-    // ignore errors.
+    telemetry.trackCli(`CACHE_STATUS`, {
+      cacheStatus: `COLD`,
+    })
+
+    return {} as IGatsbyState
   }
-  // BUG: Would this not cause downstream bugs? seems likely. Why wouldn't we just
-  // throw and kill the program?
-  telemetry.decorateEvent(`BUILD_END`, {
-    cacheStatus: `COLD`,
-  })
-  telemetry.decorateEvent(`DEVELOP_STOP`, {
-    cacheStatus: `COLD`,
-  })
-  return {} as IGatsbyState
 }
 
 export interface IMultiDispatch {