Skip to content

Commit 27e4a6a

Browse files
florinpop17wardpeet
andcommitted
fix(gatsby-remark-images): override all default styling with wrapperStyle (#12200)
Addressing issue [12199](#12199) where the default values couldn't be overwritten. Co-authored-by: Ward Peeters <[email protected]>
1 parent cdd0fe3 commit 27e4a6a

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

packages/gatsby-remark-images/src/__tests__/__snapshots__/index.js.snap

+10-10
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
exports[`it handles goofy nesting properly 1`] = `
44
"<span
55
class=\\"gatsby-resp-image-wrapper\\"
6-
style=\\"position: relative; display: block; max-width: 300px; margin-left: auto; margin-right: auto;\\"
6+
style=\\"position: relative; display: block; margin-left: auto; margin-right: auto; max-width: 300px;\\"
77
>
88
<span
99
class=\\"gatsby-resp-image-background-image\\"
@@ -24,7 +24,7 @@ exports[`it handles goofy nesting properly 1`] = `
2424
exports[`it leaves images that are already linked alone 1`] = `
2525
"<span
2626
class=\\"gatsby-resp-image-wrapper\\"
27-
style=\\"position: relative; display: block; max-width: 300px; margin-left: auto; margin-right: auto;\\"
27+
style=\\"position: relative; display: block; margin-left: auto; margin-right: auto; max-width: 300px;\\"
2828
>
2929
<span
3030
class=\\"gatsby-resp-image-background-image\\"
@@ -44,23 +44,23 @@ exports[`it leaves images that are already linked alone 1`] = `
4444

4545
exports[`it leaves linked HTML img tags alone 1`] = `
4646
"<a href=\\"https://example.org\\">
47-
<span class=\\"gatsby-resp-image-wrapper\\" style=\\"position: relative; display: block; max-width: 300px; margin-left: auto; margin-right: auto;\\">
47+
<span class=\\"gatsby-resp-image-wrapper\\" style=\\"position: relative; display: block; margin-left: auto; margin-right: auto; max-width: 300px;\\">
4848
<span class=\\"gatsby-resp-image-background-image\\" style=\\"padding-bottom: 133.33333333333331%; position: relative; bottom: 0; left: 0; background-image: url(&apos;data:image/png;base64,iVBORw&apos;); background-size: cover; display: block;\\"></span>
4949
<img class=\\"gatsby-resp-image-image\\" style=\\"width:100%;height:100%;margin:0;vertical-align:middle;position:absolute;top:0;left:0;box-shadow:inset 0px 0px 0px 400px white;\\" alt=\\"this image already has a link\\" title=\\"\\" src=\\"not-a-real-dir/images/this-image-already-has-a-link.jpeg\\" srcset=\\"not-a-real-dir/images/this-image-already-has-a-link.jpeg, not-a-real-dir/images/this-image-already-has-a-link.jpeg\\" sizes=\\"(max-width: 650px) 100vw, 650px\\">
5050
</span>
5151
</a>"
5252
`;
5353
5454
exports[`it leaves single-line linked HTML img tags alone 1`] = `
55-
"<span class=\\"gatsby-resp-image-wrapper\\" style=\\"position: relative; display: block; max-width: 300px; margin-left: auto; margin-right: auto;\\">
55+
"<span class=\\"gatsby-resp-image-wrapper\\" style=\\"position: relative; display: block; margin-left: auto; margin-right: auto; max-width: 300px;\\">
5656
<span class=\\"gatsby-resp-image-background-image\\" style=\\"padding-bottom: 133.33333333333331%; position: relative; bottom: 0; left: 0; background-image: url(&apos;data:image/png;base64,iVBORw&apos;); background-size: cover; display: block;\\"></span>
5757
<img class=\\"gatsby-resp-image-image\\" style=\\"width:100%;height:100%;margin:0;vertical-align:middle;position:absolute;top:0;left:0;box-shadow:inset 0px 0px 0px 400px white;\\" alt=\\"this image already has a link\\" title=\\"\\" src=\\"not-a-real-dir/images/this-image-already-has-a-link.jpeg\\" srcset=\\"not-a-real-dir/images/this-image-already-has-a-link.jpeg, not-a-real-dir/images/this-image-already-has-a-link.jpeg\\" sizes=\\"(max-width: 650px) 100vw, 650px\\">
5858
</span>"
5959
`;
6060
6161
exports[`it transforms HTML img tags 1`] = `
6262
"<a class=\\"gatsby-resp-image-link\\" href=\\"not-a-real-dir/image/my-image.jpeg\\" style=\\"display: block\\" target=\\"_blank\\" rel=\\"noopener\\">
63-
<span class=\\"gatsby-resp-image-wrapper\\" style=\\"position: relative; display: block; max-width: 300px; margin-left: auto; margin-right: auto;\\">
63+
<span class=\\"gatsby-resp-image-wrapper\\" style=\\"position: relative; display: block; margin-left: auto; margin-right: auto; max-width: 300px;\\">
6464
<span class=\\"gatsby-resp-image-background-image\\" style=\\"padding-bottom: 133.33333333333331%; position: relative; bottom: 0; left: 0; background-image: url(&apos;data:image/png;base64,iVBORw&apos;); background-size: cover; display: block;\\"></span>
6565
<img class=\\"gatsby-resp-image-image\\" style=\\"width:100%;height:100%;margin:0;vertical-align:middle;position:absolute;top:0;left:0;box-shadow:inset 0px 0px 0px 400px white;\\" alt=\\"my image\\" title=\\"\\" src=\\"not-a-real-dir/image/my-image.jpeg\\" srcset=\\"not-a-real-dir/image/my-image.jpeg, not-a-real-dir/image/my-image.jpeg\\" sizes=\\"(max-width: 650px) 100vw, 650px\\">
6666
</span>
@@ -69,7 +69,7 @@ exports[`it transforms HTML img tags 1`] = `
6969
7070
exports[`it transforms HTML img tags with query strings 1`] = `
7171
"<a class=\\"gatsby-resp-image-link\\" href=\\"not-a-real-dir/image/my-image.jpeg\\" style=\\"display: block\\" target=\\"_blank\\" rel=\\"noopener\\">
72-
<span class=\\"gatsby-resp-image-wrapper\\" style=\\"position: relative; display: block; max-width: 300px; margin-left: auto; margin-right: auto;\\">
72+
<span class=\\"gatsby-resp-image-wrapper\\" style=\\"position: relative; display: block; margin-left: auto; margin-right: auto; max-width: 300px;\\">
7373
<span class=\\"gatsby-resp-image-background-image\\" style=\\"padding-bottom: 133.33333333333331%; position: relative; bottom: 0; left: 0; background-image: url(&apos;data:image/png;base64,iVBORw&apos;); background-size: cover; display: block;\\"></span>
7474
<img class=\\"gatsby-resp-image-image\\" style=\\"width:100%;height:100%;margin:0;vertical-align:middle;position:absolute;top:0;left:0;box-shadow:inset 0px 0px 0px 400px white;\\" alt=\\"my image\\" title=\\"\\" src=\\"not-a-real-dir/image/my-image.jpeg\\" srcset=\\"not-a-real-dir/image/my-image.jpeg, not-a-real-dir/image/my-image.jpeg\\" sizes=\\"(max-width: 650px) 100vw, 650px\\">
7575
</span>
@@ -86,7 +86,7 @@ exports[`it transforms image references in markdown 1`] = `
8686
>
8787
<span
8888
class=\\"gatsby-resp-image-wrapper\\"
89-
style=\\"position: relative; display: block; max-width: 300px; margin-left: auto; margin-right: auto;\\"
89+
style=\\"position: relative; display: block; margin-left: auto; margin-right: auto; max-width: 300px;\\"
9090
>
9191
<span
9292
class=\\"gatsby-resp-image-background-image\\"
@@ -115,7 +115,7 @@ exports[`it transforms images in markdown 1`] = `
115115
>
116116
<span
117117
class=\\"gatsby-resp-image-wrapper\\"
118-
style=\\"position: relative; display: block; max-width: 300px; margin-left: auto; margin-right: auto;\\"
118+
style=\\"position: relative; display: block; margin-left: auto; margin-right: auto; max-width: 300px;\\"
119119
>
120120
<span
121121
class=\\"gatsby-resp-image-background-image\\"
@@ -144,7 +144,7 @@ exports[`it transforms images in markdown with query strings 1`] = `
144144
>
145145
<span
146146
class=\\"gatsby-resp-image-wrapper\\"
147-
style=\\"position: relative; display: block; max-width: 300px; margin-left: auto; margin-right: auto;\\"
147+
style=\\"position: relative; display: block; margin-left: auto; margin-right: auto; max-width: 300px;\\"
148148
>
149149
<span
150150
class=\\"gatsby-resp-image-background-image\\"
@@ -173,7 +173,7 @@ exports[`it uses tracedSVG placeholder when enabled 1`] = `
173173
>
174174
<span
175175
class=\\"gatsby-resp-image-wrapper\\"
176-
style=\\"position: relative; display: block; max-width: 300px; margin-left: auto; margin-right: auto;\\"
176+
style=\\"position: relative; display: block; margin-left: auto; margin-right: auto; max-width: 300px;\\"
177177
>
178178
<span
179179
class=\\"gatsby-resp-image-background-image\\"

packages/gatsby-remark-images/src/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,9 @@ module.exports = (
245245
let rawHTML = `
246246
<span
247247
class="${imageWrapperClass}"
248-
style="position: relative; display: block; ${
248+
style="position: relative; display: block; margin-left: auto; margin-right: auto; ${
249249
showCaptions ? `` : wrapperStyle
250-
} max-width: ${presentationWidth}px; margin-left: auto; margin-right: auto;"
250+
} max-width: ${presentationWidth}px;"
251251
>
252252
<span
253253
class="${imageBackgroundClass}"

0 commit comments

Comments
 (0)