fix(gatsby-plugin-offline): prevent caching invalid relative paths (#17406)

vtenfys · GatsbyJS Bot · commit 19ee1750a950 · 2019-09-05T15:36:29.000+05:30
diff --git a/packages/gatsby-plugin-offline/src/get-resources-from-html.js b/packages/gatsby-plugin-offline/src/get-resources-from-html.js
@@ -43,7 +43,7 @@ module.exports = (htmlPath, pathPrefix) => {
 
     // check resource URLs from header tags start with the correct prefix
     // (these are not page URLs)
-    if (!blackListRegex.test(url) && url.startsWith(pathPrefix)) {
+    if (!blackListRegex.test(url) && url.startsWith(`${pathPrefix}/`)) {
       criticalFilePaths.push(url.replace(/^\//, ``))
     }
   })

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ module.exports = (htmlPath, pathPrefix) => {`
`43`	`43`
`44`	`44`	`// check resource URLs from header tags start with the correct prefix`
`45`	`45`	`// (these are not page URLs)`
`46`		`- if (!blackListRegex.test(url) && url.startsWith(pathPrefix)) {`
	`46`	+ if (!blackListRegex.test(url) && url.startsWith(`${pathPrefix}/`)) {
`47`	`47`	criticalFilePaths.push(url.replace(/^\//, ``))
`48`	`48`	`}`
`49`	`49`	`})`