fix(gatsby-plugin-offline): versioned import of idb-keyval (#24938)

* fix(sw): versioned import of idb-keyval

with the version included it is ok to cache it immutable alongside the other fingerprinted js files produced by Gatsby

* style: fix linting errors

* fix(sw): replace versioned import in sw-append.js

Author: nibtime

packages/gatsby-plugin-offline/src/gatsby-node.js

@@ -162,7 +162,9 @@ exports.onPostBuild = (
 
   const idbKeyvalFile = `idb-keyval-iife.min.js`
   const idbKeyvalSource = require.resolve(`idb-keyval/dist/${idbKeyvalFile}`)
-  const idbKeyvalDest = `public/${idbKeyvalFile}`
+  const idbKeyvalPackageJson = require(`idb-keyval/package.json`)
+  const idbKeyValVersioned = `idb-keyval-${idbKeyvalPackageJson.version}-iife.min.js`
+  const idbKeyvalDest = `public/${idbKeyValVersioned}`
   fs.createReadStream(idbKeyvalSource).pipe(fs.createWriteStream(idbKeyvalDest))
 
   const swDest = `public/sw.js`
@@ -183,6 +185,7 @@ exports.onPostBuild = (
 
       const swAppend = fs
         .readFileSync(`${__dirname}/sw-append.js`, `utf8`)
+        .replace(/%idbKeyValVersioned%/g, idbKeyValVersioned)
         .replace(/%pathPrefix%/g, pathPrefix)
         .replace(/%appFile%/g, appFile)
 

packages/gatsby-plugin-offline/src/sw-append.js

@@ -1,6 +1,5 @@
 /* global importScripts, workbox, idbKeyval */
-
-importScripts(`idb-keyval-iife.min.js`)
+importScripts(`%idbKeyValVersioned%`)
 
 const { NavigationRoute } = workbox.routing