Skip to content

Commit 16da88c

Browse files
twoertweingasparitiago
authored andcommitted
CI/TYP: run pyright at manual stage in pre-commit (pandas-dev#43799)
1 parent 0fb4048 commit 16da88c

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.github/workflows/pre-commit.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ jobs:
1313
concurrency:
1414
group: ${{ github.ref }}-pre-commit
1515
cancel-in-progress: ${{github.event_name == 'pull_request'}}
16-
env:
17-
SKIP: pyright
1816
steps:
1917
- uses: actions/checkout@v2
2018
- uses: actions/setup-python@v2

.pre-commit-config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ repos:
8989
language: node
9090
pass_filenames: false
9191
types: [python]
92+
stages: [manual]
9293
# note: keep version in sync with .github/workflows/ci.yml
9394
additional_dependencies: ['[email protected]']
9495
- repo: local

doc/source/development/contributing_codebase.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,10 +402,12 @@ pandas uses `mypy <http://mypy-lang.org>`_ and `pyright <https://github.com/micr
402402
mypy pandas
403403
404404
# let pre-commit setup and run pyright
405-
pre-commit run --all-files pyright
405+
pre-commit run --hook-stage manual --all-files pyright
406406
# or if pyright is installed (requires node.js)
407407
pyright
408408
409+
A recent version of ``numpy`` (>=1.21.0) is required for type validation.
410+
409411
.. _contributing.ci:
410412

411413
Testing with continuous integration

0 commit comments

Comments
 (0)