Refactor

Author: sebastianbergmann

.psalm/baseline.xml

@@ -910,6 +910,8 @@
       <code><![CDATA[logEventsVerboseText]]></code>
       <code><![CDATA[logEventsVerboseText]]></code>
       <code><![CDATA[logfileJunit]]></code>
+      <code><![CDATA[logfileJunit]]></code>
+      <code><![CDATA[logfileTeamcity]]></code>
       <code><![CDATA[logfileTeamcity]]></code>
     </MissingThrowsDocblock>
     <UnresolvableInclude>

src/Runner/Exception/DirectoryCannotBeCreatedException.php

@@ -7,7 +7,7 @@
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
-namespace PHPUnit\TextUI;
+namespace PHPUnit\Runner;
 
 use function sprintf;
 use RuntimeException;

src/TextUI/Exception/DirectoryDoesNotExistException.php renamed to src/Runner/Exception/DirectoryDoesNotExistException.php

@@ -21,7 +21,7 @@
 use function json_decode;
 use function json_encode;
 use PHPUnit\Framework\TestStatus\TestStatus;
-use PHPUnit\Runner\DirectoryCannotBeCreatedException;
+use PHPUnit\Runner\DirectoryDoesNotExistException;
 use PHPUnit\Runner\Exception;
 use PHPUnit\Util\Filesystem;
 
@@ -130,7 +130,7 @@ public function load(): void
     public function persist(): void
     {
         if (!Filesystem::createDirectory(dirname($this->cacheFilename))) {
-            throw new DirectoryCannotBeCreatedException($this->cacheFilename);
+            throw new DirectoryDoesNotExistException(dirname($this->cacheFilename));
         }
 
         $data = [

src/Runner/ResultCache/DefaultResultCache.php

@@ -33,6 +33,7 @@
 use PHPUnit\Runner\Baseline\Reader;
 use PHPUnit\Runner\Baseline\Writer;
 use PHPUnit\Runner\CodeCoverage;
+use PHPUnit\Runner\DirectoryDoesNotExistException;
 use PHPUnit\Runner\ErrorHandler;
 use PHPUnit\Runner\Extension\ExtensionBootstrapper;
 use PHPUnit\Runner\Extension\Facade as ExtensionFacade;
@@ -215,7 +216,7 @@ public function run(array $argv): int
                     OutputFacade::printerFor($configuration->logfileTestdoxHtml())->print(
                         (new TestDoxHtmlRenderer)->render($testDoxResult),
                     );
-                } catch (Exception $e) {
+                } catch (DirectoryDoesNotExistException|InvalidSocketException $e) {
                     EventFacade::emitter()->testRunnerTriggeredWarning(
                         sprintf(
                             'Cannot log test results in TestDox HTML format to "%s": %s',
@@ -232,7 +233,7 @@ public function run(array $argv): int
                     OutputFacade::printerFor($configuration->logfileTestdoxText())->print(
                         (new TestDoxTextRenderer)->render($testDoxResult),
                     );
-                } catch (Exception $e) {
+                } catch (DirectoryDoesNotExistException|InvalidSocketException $e) {
                     EventFacade::emitter()->testRunnerTriggeredWarning(
                         sprintf(
                             'Cannot log test results in TestDox plain text format to "%s": %s',
@@ -570,7 +571,7 @@ private function registerLogfileWriters(Configuration $configuration): void
                     OutputFacade::printerFor($configuration->logfileJunit()),
                     EventFacade::instance(),
                 );
-            } catch (Exception $e) {
+            } catch (DirectoryDoesNotExistException|InvalidSocketException $e) {
                 EventFacade::emitter()->testRunnerTriggeredWarning(
                     sprintf(
                         'Cannot log test results in JUnit XML format to "%s": %s',
@@ -589,7 +590,7 @@ private function registerLogfileWriters(Configuration $configuration): void
                     ),
                     EventFacade::instance(),
                 );
-            } catch (Exception $e) {
+            } catch (DirectoryDoesNotExistException|InvalidSocketException $e) {
                 EventFacade::emitter()->testRunnerTriggeredWarning(
                     sprintf(
                         'Cannot log test results in TeamCity format to "%s": %s',

src/TextUI/Application.php

@@ -15,9 +15,9 @@
 use PHPUnit\Event\UnknownSubscriberTypeException;
 use PHPUnit\Logging\TeamCity\TeamCityLogger;
 use PHPUnit\Logging\TestDox\TestResultCollection;
+use PHPUnit\Runner\DirectoryDoesNotExistException;
 use PHPUnit\TestRunner\TestResult\TestResult;
 use PHPUnit\TextUI\Configuration\Configuration;
-use PHPUnit\TextUI\DirectoryDoesNotExistException;
 use PHPUnit\TextUI\InvalidSocketException;
 use PHPUnit\TextUI\Output\Default\ProgressPrinter\ProgressPrinter as DefaultProgressPrinter;
 use PHPUnit\TextUI\Output\Default\ResultPrinter as DefaultResultPrinter;

src/TextUI/Output/Facade.php

@@ -19,7 +19,7 @@
 use function fwrite;
 use function str_replace;
 use function str_starts_with;
-use PHPUnit\TextUI\DirectoryDoesNotExistException;
+use PHPUnit\Runner\DirectoryDoesNotExistException;
 use PHPUnit\TextUI\InvalidSocketException;
 use PHPUnit\Util\Filesystem;