renaming to redirect

Author: mschile

test-apps/new-cypress-config/redirect/cypress/plugins/index.js

@@ -1,8 +1,10 @@
-// The redirect code needs to be un-instrumented, otherwise the statement map will be different depending on which code path the redirect took. 
-// If the redirect code is instrumented, Cypress would then treat them as different coverage objects and merge the code coverage (not testing what we want).
-// If the redirect code is un-instrumented, Cypress can't tell them apart and will update the existing coverage object to point to the correct one.
-// Timeouts are necessary to allow cypress to pick up the "initial" coverage object and compare it to the existing coverage objects.
+// This redirect code needs to be un-instrumented (excluded in .nycrc.json)
+// - If the redirect code is instrumented, Cypress would then treat them as different coverage objects and merge the code coverage (not testing what we want).
+// - If the redirect code is un-instrumented, Cypress can't tell them apart and will update the existing coverage object to point to the correct one (testing what we want).
+
+import { returnToApp } from './utils'
 
+// Timeouts are necessary to allow cypress to pick up the "initial" coverage object and compare it to the existing coverage objects.
 new Promise((resolve) => {
   if (window.location.port === '1234' && !localStorage.getItem('visited')) {
     localStorage.setItem('visited', true)
@@ -22,6 +24,5 @@ new Promise((resolve) => {
     }, 500)
   }
 }).then(() => {
-  document.body
-    .appendChild(document.createTextNode('Returned to app'))
+  returnToApp()
 })

test-apps/new-cypress-config/redirect/cypress/support/e2e.js

@@ -4,7 +4,8 @@ module.exports = defineConfig({
   fixturesFolder: false,
   e2e: {
     setupNodeEvents(on, config) {
-      return require('./cypress/plugins/index.js')(on, config)
+      require('@cypress/code-coverage/task')(on, config)
+      return config
     },
     baseUrl: 'http://localhost:1234',
     env: {

test-apps/new-cypress-config/redirect/package.json

@@ -3,11 +3,9 @@
 /// <reference types="Cypress" />
 
 context('Page test', () => {
-
-  it('logs names', function() {
+  it('redirects back to the app', function() {
     cy.clearLocalStorage()
     cy.visit("http://localhost:1234")
     cy.contains("Returned to app")
   })
-
 })

test-apps/new-cypress-config/redirect/.babelrc renamed to test-apps/redirect/.babelrc

@@ -1,2 +1 @@
 import '@cypress/code-coverage/support'
-console.log('this is commands file')

test-apps/new-cypress-config/redirect/.nycrc.json renamed to test-apps/redirect/.nycrc.json

@@ -0,0 +1,16 @@
+{
+  "name": "example-redirect",
+  "description": "Tests a frontend app that redirects, through un-instrumented code, back to itself.",
+  "devDependencies": {
+    "@babel/core": "^7.12.0"
+  },
+  "scripts": {
+    "cy:run": "cypress run",
+    "start:app": "parcel serve -p 1234 index.html",
+    "start:other-app": "parcel serve -p 1235 index.html",
+    "pretest": "rimraf .nyc_output .cache coverage dist",
+    "test": "start-test start:app http://localhost:1234 start:other-app http://localhost:1235 cy:run",
+    "coverage:verify": "npx nyc report --check-coverage true --lines 100",
+    "coverage:check-files": "check-coverage utils.js && only-covered utils.js"
+  }
+}

test-apps/new-cypress-config/redirect/README.md renamed to test-apps/redirect/README.md

@@ -0,0 +1,4 @@
+export const returnToApp = () => {
+  document.body
+    .appendChild(document.createTextNode('Returned to app'))
+}