Move from POSIXError to URLError for URLSessionWebSocketTask. URLError is suitable for use on Windows, whereas POSIXError is not

Paul Seligman · Paul Seligman · commit 6f6cbb9cef16 · 2022-11-17T10:40:32.000-05:00
diff --git a/Sources/FoundationNetworking/URLSession/URLSessionTask.swift b/Sources/FoundationNetworking/URLSession/URLSessionTask.swift
@@ -754,7 +754,9 @@ open class URLSessionWebSocketTask : URLSessionTask {
                             pongReceiveHandler(error)
                         }
                     } else {
-                        pongReceiveHandler(POSIXError(.ENOTCONN))
+                        let disconnectedError = URLError(_nsError: NSError(domain: NSURLErrorDomain,
+                                                                           code: NSURLErrorNetworkConnectionLost))
+                        pongReceiveHandler(disconnectedError)
                     }
                 }
             }
@@ -782,7 +784,8 @@ open class URLSessionWebSocketTask : URLSessionTask {
             
             self.closeCode = code
             self.closeReason = reason
-            self.taskError = POSIXError(.ENOTCONN)
+            self.taskError = URLError(_nsError: NSError(domain: NSURLErrorDomain,
+                                                        code: NSURLErrorNetworkConnectionLost))
             self.closeMessage = (code, reason ?? Data())
             self.doPendingWork()
         }

Original file line number	Diff line number	Diff line change
`@@ -754,7 +754,9 @@ open class URLSessionWebSocketTask : URLSessionTask {`
`754`	`754`	`pongReceiveHandler(error)`
`755`	`755`	`}`
`756`	`756`	`} else {`
`757`		`- pongReceiveHandler(POSIXError(.ENOTCONN))`
	`757`	`+ let disconnectedError = URLError(_nsError: NSError(domain: NSURLErrorDomain,`
	`758`	`+ code: NSURLErrorNetworkConnectionLost))`
	`759`	`+ pongReceiveHandler(disconnectedError)`
`758`	`760`	`}`
`759`	`761`	`}`
`760`	`762`	`}`
`@@ -782,7 +784,8 @@ open class URLSessionWebSocketTask : URLSessionTask {`
`782`	`784`
`783`	`785`	`self.closeCode = code`
`784`	`786`	`self.closeReason = reason`
`785`		`- self.taskError = POSIXError(.ENOTCONN)`
	`787`	`+ self.taskError = URLError(_nsError: NSError(domain: NSURLErrorDomain,`
	`788`	`+ code: NSURLErrorNetworkConnectionLost))`
`786`	`789`	`self.closeMessage = (code, reason ?? Data())`
`787`	`790`	`self.doPendingWork()`
`788`	`791`	`}`