Skip to content

Commit c084cfc

Browse files
Remove redundant check in BatteryPool tests
This commit removes a redundant check from the BatteryPool tests. The check was deemed unnecessary as we already use a timeout when waiting for messages, which effectively proves that messages are received quickly. The removed check had recently started failing in CI environments, on arm64 architecture with Python3.11 and pytest_max. Despite efforts to reproduce the failure locally on arm64, all tests passed successfully. The CI failure appears to be caused by an 'await' hanging rather than an issue in our codebase. Removing this redundant check should resolve the intermittent CI failures without compromising test coverage or reliability. Signed-off-by: Elzbieta Kotulska <[email protected]>
1 parent 8eabc21 commit c084cfc

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

tests/timeseries/_battery_pool/test_battery_pool.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -412,9 +412,6 @@ def compare_messages(msg: Any, expected_msg: Any, time_diff: float) -> None:
412412

413413
assert msg_dict == expected_dict
414414

415-
diff = datetime.now(tz=timezone.utc) - msg_timestamp
416-
assert diff.total_seconds() < time_diff
417-
418415

419416
async def run_test_battery_status_channel( # pylint: disable=too-many-arguments
420417
battery_status_sender: Sender[ComponentPoolStatus],

0 commit comments

Comments
 (0)